-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product format error message #998
Comments
It's not like we don't support This error happens because Ploomber determined that one of the tasks is a notebook. Hence, it requires one of the products to be a notebook (so we store the output notebook there). For example, the pipeline might be something like this: tasks:
- source: notebook.ipynb
product: something.pkl Ploomber will throw the error since it expects one of the products to be either an tasks:
- source: notebook.ipynb
product:
nb: output.ipynb # or output.html, output.pdf, etc
data: something.pkl Note that the same would happen if the source is a script, since Ploomber converts scripts to notebooks and then executes them. This would generate the same error: tasks:
- source: script.py
product: something.pkl Because we expects something like: tasks:
- source: script.py
product:
nb: output.ipynb
data: something.pkl I agree that the error is confusing, and the code should run even if the path to the output notebook is missing. Here's my proposed solution:
|
Is this issue available, can I work on this issue? |
I'd like to work on this issue too with @aadityasinha-dotcom |
sure @aadityasinha-dotcom, @abhishak3. feel free to work on it. assigned it to both. feel free to work independently or together. |
We need to support pkl as a format, or if supported but missing the dictionary key, we should adjust the error message to be specific and give an example (for instance, to pass a pickle product do
product: 'file.pkl'
). We should also include a link to our community slack channel.The text was updated successfully, but these errors were encountered: