Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor email between GitHub and commits must match #1716

Closed
stevepiercy opened this issue Sep 26, 2024 · 5 comments · Fixed by #1722
Closed

Contributor email between GitHub and commits must match #1716

stevepiercy opened this issue Sep 26, 2024 · 5 comments · Fixed by #1722

Comments

@stevepiercy
Copy link
Contributor

stevepiercy commented Sep 26, 2024

During the Salamina sprint, we discovered that if the emails between your GitHub user account and your commits do not match, then mr.roboto will complain.

To remedy this, we need to document that the contributor's emails between GitHub and commits must match. Here's the proposed snippet to use. @mauritsvanrees @fredvd @folix-01 would you please review?

When pushing a commit to GitHub, the email address in your commit must match an email address in your GitHub account. If it does not match, then `mr.roboto` will notify you that there is a problem that prevents your pull request from being merged.

To change the email address in your commits, see [Setting your commit email address](https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address].

To add an email address to your GitHub account, see [Adding an email address to your GitHub account](https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account).

We also need to update the mr.roboto message with this clarity and for consistency , and add it to the PCA page at https://plone.org/foundation/contributors-agreement. I'll submit an issue or PR as needed.

Originally posted by @stevepiercy in plone/mr.roboto#163 (comment)

@folix-01
Copy link
Member

folix-01 commented Sep 27, 2024

When pushing a commit to GitHub, the email address in your commit must match an email address in your GitHub account. If it does not match, then `mr.roboto` will notify you that there is a problem that prevents your pull request from being merged.

To change the email address in your commits, see [Setting your commit email address](https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address].

To add an email address to your GitHub account, see [Adding an email address to your GitHub account](https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account).

In my opinion, this snippet is enaught informative.

@stevepiercy
Copy link
Contributor Author

"enaught"? Do you mean "enough"?

@folix-01
Copy link
Member

"enaught"? Do you mean "enough"?

Yeah "enough". My bad sorry :D

@stevepiercy
Copy link
Contributor Author

@folix-01 no worries. Thanks for the feedback. I'll make it happen.

@stevepiercy
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants