Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename collectionCode to institutionCode #27

Open
myrmoteras opened this issue Nov 8, 2022 · 5 comments
Open

rename collectionCode to institutionCode #27

myrmoteras opened this issue Nov 8, 2022 · 5 comments

Comments

@myrmoteras
Copy link

We would like to suggest to rename collectionCode as institutionCode (DWC term need to be checked), because almost all the collection codes are in fact institution codes.

see also

@gsautter
Copy link
Contributor

gsautter commented Nov 8, 2022

The trouble with a general renaming is that we have the collectionCode annotation type in a ton of places (sort of a historically grown thing), so renaming it in the data is quite the endeavor ... the DwCAs have had the term corrected already, so it should be correct in GBIF and this for the matching service.

@myrmoteras
Copy link
Author

As long as it is clear that GGI collectionCode is DWC institutionCode in our DWCA then this is ok, as we can see here

image
from https://tb.plazi.org/GgServer/summary/C8083D6ADB684F11FF90B471FF88F55A and DWCA https://tb.plazi.org/GgServer/dwca/C8083D6ADB684F11FF90B471FF88F55A.zip

What is the plan to update the old documents? As part of the great batch?

@gsautter
Copy link
Contributor

gsautter commented Nov 8, 2022

What is the plan to update the old documents? As part of the great batch?

DwCAs are re-packed on updates, so the batch will effect a DwCA update for every document it changes ... whatever rest remains I'll re-trigger manually (via the server console) afterwards.

@gsautter
Copy link
Contributor

gsautter commented Nov 8, 2022

As long as it is clear that GGI collectionCode is DWC institutionCode in our DWCA then this is ok, as we can see here

Well, GGI will simply remain what we're used to for now ... might even gradually switch from the outside in, it's just too risky to make the change in one big go ... which is the exact reason we decided to change the DwCAs for starters.

@myrmoteras
Copy link
Author

fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants