-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surprising behavior with Appendable subclasses. #84
Labels
Comments
I just ran into the same issue with HtmlFormat. Here's a simple reproduction:
renders as:
This makes it impossible to implement any meaningful subclasses of It's not clear to me why it doesn't pick the correct static overload in the first place but at least the dynamic version should behave the same (i.e. allows subtypes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a custom format that escapes
|
asbar
.src/main/scala/example/Example.scala
src/main/twirl/example/my.ex
The result of
example.ex.my("bar")
isbar bar bar
instead of| bar |
.The template text is unexpectedly being escaped. This is because the runtime type is not
Example
and https://github.com/playframework/twirl/blob/master/api/src/main/scala/play/twirl/api/BaseScalaTemplate.scala#L20.This could be improved to be
T
or a subtype, instead of onlyT
.(More generally, I feel like the runtime type branching in
BaseScalaTemplate
could be eliminated.)The text was updated successfully, but these errors were encountered: