Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slick-context documented but not used #230

Open
arobertn opened this issue Feb 17, 2015 · 0 comments
Open

slick-context documented but not used #230

arobertn opened this issue Feb 17, 2015 · 0 comments

Comments

@arobertn
Copy link

Please correct me if I'm wrong, but it appears that the recommended configuration of an Akka "slick-context" here: https://github.com/playframework/play-slick/wiki/ScalaSlickThreads

is not actually used for anything. According to the docs here:

https://www.playframework.com/documentation/2.3.x/ThreadPools

such custom execution contexts need to be explicitly referenced somewhere in the code (as in, 'Akka.system.dispatchers.lookup("my-context")') in order to be used. I can find no such code anywhere in play-slick (although there was at one time) Instead, there is the SlickExecutionContext object which creates a threadpool executor based on min/max DB connections.

In any case it would be good to clearly document how the threading and connections are managed. The relation between the BoneCP configuration, Play's Akka default dispatcher, and this play-slick threadpool are not particularly clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants