Skip to content

Latest version of playcanvas (2.6.1) breaks demo with @playcanvas/react 0.2.4 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kennethlynne opened this issue Apr 1, 2025 · 7 comments

Comments

@kennethlynne
Copy link

I'm trying to debug why an upgrade from 2.5.0 broke my code, but it seems we need to upgrade playcanvas in this lib and demos too

Reproducible: https://codesandbox.io/p/devbox/playcanvas-react-forked-g53qwk?workspaceId=ws_UsB7cAkgRvYEUA7XV36h7M

Image

@kennethlynne
Copy link
Author

Basically bumping to latest in this demo

Image

@kennethlynne
Copy link
Author

Using @playcanvas/[email protected] I am unable to use any version of playcanvas above 2.5.0

Already in 2.5.1 I start seeing issues like this:

Image

@kennethlynne kennethlynne changed the title Latest version of playcanvas (2.6.1) breaks demo Latest version of playcanvas (2.6.1) breaks demo with @playcanvas/react 0.2.4 Apr 1, 2025
@marklundin
Copy link
Member

Thanks for reporting @kennethlynne. This does looks like an underlying breaking change in the engine. I will flag this with the team

@marklundin
Copy link
Member

Ok, so my misunderstanding. The engine doesn't actually follow semantic versioning and Minor releases may include breaking changes. So the peer dependancy should actually be ~2.3.1 and not ^2.3.1. I'll update this and also look at fixing the above

@willeastcott
Copy link

I think that's overstating things a little. We do try to ensure the Engine follows semantic versioning as much as it can and we go to great lengths to ensure backwards compatibility. But sometimes some minor breaking changes can go out with a minor release. This is often around areas of the engine that aren't finalized. But when it happens, we try to call it out in the release notes.

@marklundin
Copy link
Member

Maybe @mvaligursky can chime in here as we spoke about this offline.

These look like two separate breaking changes to Scripts. While Scripts aren’t part of the core engine, they are versioned alongside it—so these changes will break things.

Breaking changes are fine, but consumers needs to confidently link to a safe version range for patches with some guarantee things won't break.

@mvaligursky
Copy link

I agree that ~2.3.1 seems to be the solution here.
If a new minor version of the engine is updated, this needs to be tested on the side of this library and issues (if any) fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants