-
Notifications
You must be signed in to change notification settings - Fork 14
Latest version of playcanvas (2.6.1) breaks demo with @playcanvas/react 0.2.4 #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Using @playcanvas/[email protected] I am unable to use any version of playcanvas above 2.5.0 Already in 2.5.1 I start seeing issues like this: |
Thanks for reporting @kennethlynne. This does looks like an underlying breaking change in the engine. I will flag this with the team |
Ok, so my misunderstanding. The engine doesn't actually follow semantic versioning and Minor releases may include breaking changes. So the peer dependancy should actually be |
I think that's overstating things a little. We do try to ensure the Engine follows semantic versioning as much as it can and we go to great lengths to ensure backwards compatibility. But sometimes some minor breaking changes can go out with a minor release. This is often around areas of the engine that aren't finalized. But when it happens, we try to call it out in the release notes. |
Maybe @mvaligursky can chime in here as we spoke about this offline. These look like two separate breaking changes to Scripts. While Scripts aren’t part of the core engine, they are versioned alongside it—so these changes will break things. Breaking changes are fine, but consumers needs to confidently link to a safe version range for patches with some guarantee things won't break. |
I agree that |
I'm trying to debug why an upgrade from 2.5.0 broke my code, but it seems we need to upgrade playcanvas in this lib and demos too
Reproducible: https://codesandbox.io/p/devbox/playcanvas-react-forked-g53qwk?workspaceId=ws_UsB7cAkgRvYEUA7XV36h7M
The text was updated successfully, but these errors were encountered: