Skip to content

Commit b9db7d6

Browse files
committed
[PCD-447] Trim leading and trailing whitespaces
1 parent d70e375 commit b9db7d6

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

pkg/config/config.go

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ func ConfigCmdCreateAmazonRun(cfg *objects.Config) error {
204204
if cfg.AwsIamUsername == "" {
205205
fmt.Printf("Amazon IAM User: ")
206206
awsIamUsername, _ := reader.ReadString('\n')
207-
cfg.AwsIamUsername = strings.TrimSuffix(awsIamUsername, "\n")
207+
cfg.AwsIamUsername = strings.TrimSpace(awsIamUsername)
208208
}
209209

210210
if cfg.AwsAccessKey == "" {
@@ -224,7 +224,7 @@ func ConfigCmdCreateAmazonRun(cfg *objects.Config) error {
224224
if cfg.AwsRegion == "" {
225225
fmt.Printf("Region: ")
226226
region, _ = reader.ReadString('\n')
227-
cfg.AwsRegion = strings.TrimSuffix(region, "\n")
227+
cfg.AwsRegion = strings.TrimSpace(region)
228228
}
229229

230230
if cfg.AwsRegion == "" {
@@ -278,19 +278,19 @@ func ConfigCmdCreateGoogleRun(cfg *objects.Config) error {
278278
if cfg.GooglePath == "" {
279279
fmt.Printf("Service JSON path: ")
280280
googleProjectName, _ := reader.ReadString('\n')
281-
cfg.GoogleProjectName = strings.TrimSuffix(googleProjectName, "\n")
281+
cfg.GoogleProjectName = strings.TrimSpace(googleProjectName)
282282
}
283283

284284
if cfg.GoogleProjectName == "" {
285285
fmt.Printf("Project Name: ")
286286
googleProjectName, _ := reader.ReadString('\n')
287-
cfg.GoogleProjectName = strings.TrimSuffix(googleProjectName, "\n")
287+
cfg.GoogleProjectName = strings.TrimSpace(googleProjectName)
288288
}
289289

290290
if cfg.GoogleServiceEmail == "" {
291291
fmt.Printf("Service Account Email: ")
292292
googleServiceEmail, _ := reader.ReadString('\n')
293-
cfg.GoogleServiceEmail = strings.TrimSuffix(googleServiceEmail, "\n")
293+
cfg.GoogleServiceEmail = strings.TrimSpace(googleServiceEmail)
294294
}
295295

296296
return nil
@@ -306,13 +306,13 @@ func ConfigCmdCreateRun(cfg *objects.Config) error {
306306
if cfg.Fqdn == "" {
307307
fmt.Printf("Platform9 Account URL: ")
308308
fqdn, _ := reader.ReadString('\n')
309-
cfg.Fqdn = strings.TrimSuffix(fqdn, "\n")
309+
cfg.Fqdn = strings.TrimSpace(fqdn)
310310
}
311311

312312
if cfg.Username == "" {
313313
fmt.Printf("Username: ")
314314
username, _ := reader.ReadString('\n')
315-
cfg.Username = strings.TrimSuffix(username, "\n")
315+
cfg.Username = strings.TrimSpace(username)
316316
}
317317

318318
if cfg.Password == "" {
@@ -325,19 +325,19 @@ func ConfigCmdCreateRun(cfg *objects.Config) error {
325325
if cfg.Region == "" {
326326
fmt.Printf("Region [RegionOne]: ")
327327
region, _ = reader.ReadString('\n')
328-
cfg.Region = strings.TrimSuffix(region, "\n")
328+
cfg.Region = strings.TrimSpace(region)
329329
}
330330
var service string
331331
if cfg.Tenant == "" {
332332
fmt.Printf("Tenant [service]: ")
333333
service, _ = reader.ReadString('\n')
334-
cfg.Tenant = strings.TrimSuffix(service, "\n")
334+
cfg.Tenant = strings.TrimSpace(service)
335335
}
336336
var proxyURL string
337337
if cfg.ProxyURL == "" {
338338
fmt.Print("Proxy URL [None]: ")
339339
proxyURL, _ = reader.ReadString('\n')
340-
cfg.ProxyURL = strings.TrimSuffix(proxyURL, "\n")
340+
cfg.ProxyURL = strings.TrimSpace(proxyURL)
341341
}
342342

343343
if cfg.Region == "" {
@@ -352,7 +352,7 @@ func ConfigCmdCreateRun(cfg *objects.Config) error {
352352
if cfg.MfaToken == "" {
353353
fmt.Print("MFA Token [None]: ")
354354
mfaToken, _ = reader.ReadString('\n')
355-
cfg.MfaToken = strings.TrimSuffix(mfaToken, "\n")
355+
cfg.MfaToken = strings.TrimSpace(mfaToken)
356356
}
357357

358358
return SetProxy(cfg.ProxyURL)

pkg/pmk/cluster.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ func Bootstrap(ctx objects.Config, c client.Client, req qbert.ClusterCreateReque
6767
if err != nil {
6868
return fmt.Errorf("Unable to execute command: %w", err)
6969
}
70-
nodeID := strings.TrimSuffix(string(output), "\n")
70+
nodeID := strings.TrimSpace(string(output))
7171

7272
LoopVariable := 1
7373
for LoopVariable <= util.MaxLoopValue {

pkg/pmk/node.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ func PrepNode(ctx objects.Config, allClients client.Client, auth keystone.Keysto
165165
s.Restart()
166166
s.Suffix = " Authorising host"
167167
zap.S().Debug("Authorising host")
168-
hostID := strings.TrimSuffix(output, "\n")
168+
hostID := strings.TrimSpace(output)
169169
time.Sleep(ctx.WaitPeriod * time.Second)
170170

171171
if err := allClients.Resmgr.AuthorizeHost(hostID, auth.Token, util.KubeVersion); err != nil {

0 commit comments

Comments
 (0)