Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust crate usage #42

Closed
mdbond opened this issue May 9, 2024 · 2 comments
Closed

Rust crate usage #42

mdbond opened this issue May 9, 2024 · 2 comments

Comments

@mdbond
Copy link

mdbond commented May 9, 2024

The instructions for Rust support don't quite work because the version of Rust crate chatdbg on crates.io lacks one line in lib.rs that's present in the ChatDBG GitHub repo:

pub use chatdbg_macros::main;

As a result,

#[chatdbg::main]

gives a compiler error because it doesn't refer to chatdbg_macros::main.

Suggested fixes:

  • Provide new version of chatdbg on crates.io OR
  • Change README's Rust instructions so Cargo.toml imports chatdbg_macros (instead of chatdbg) and main file uses #[chatdbg_macros::main] annotation (instead of #[chatdbg::main] annotation)

ChatDBG is cool work! Thanks for making it available!

@nicovank
Copy link
Collaborator

Thanks for the report!

Emery just managed to push the updated version to crates.io, [email protected]. I tested locally and it seemed to have fixed the issue. I have been trying to make this automatic along with the PyPI release, ran into some permission issues.

I also think we should maybe publish a single crate instead of two and make one an alias of the other but that's another issue.

@nicovank
Copy link
Collaborator

nicovank commented Jun 6, 2024

Closing this, Rust crates should now update automatically after each release 👍

Talked with Noah about merging the two, but it looks like it is recommended and common practice to have two for those macro crates, at least as of today.

@nicovank nicovank closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants