Skip to content
This repository has been archived by the owner on Jul 19, 2022. It is now read-only.

Feature/added feature image opening #27

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Aceee-dev
Copy link

Added features :

  1. Shows date for which image is downloaded
  2. Adds more control whether user wants to see downloaded picture or not.

demo_commit1

@@ -1,5 +1,5 @@
*.pyc

**/.vscode/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't a single * suffice?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will change this .

@@ -12,6 +12,7 @@
from felicette.utils.sys_utils import exit_cli, remove_dir
from felicette.sat_processor import process_landsat_data


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all formatting errors, like 'newline', 'deleted lines', is black used?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I have not used black but certainly will use it improve the code formatting. Thank for feedback.

@@ -24,6 +24,21 @@ def handle_prompt_response(response):
exit_cli(rprint, "[red]Sorry, invalid response. Exiting :([/red]")


def handle_img_prompt_response(response_show_image,paths,key,message):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this function is redundant, because then we are asking twice if the user wants to go ahead with the download.

"Are you sure you want to see an enhanced version of the image at the path shown above? [Y/n]"

@@ -37,6 +52,7 @@ def search_landsat_data(coordinates, cloud_cover_lt):
# improvement: filter by date, cloud cover here

search_items = search.items()
print("Date at which picture was taken : " + str(search_items[0].date))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we save this to a .metadata file? Not just the date but if you try and print

return landsat_item

you'll see cloud cover, radiance and other factors. Please explore and suggest how the '.metadata' file will be for an image?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do that.

@@ -58,6 +74,12 @@ def preview_landsat_image(landsat_item):
# print success info
rprint("[blue]Preview image saved at:[/blue]")
print(paths["preview"])
logging.info("preview imagery !!!")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to comment on handle_img_prompt_response.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants