Skip to content

Commit 828d9cf

Browse files
committed
Fix static macOS framework build settings
1 parent fd68bb7 commit 828d9cf

File tree

2 files changed

+22
-13
lines changed

2 files changed

+22
-13
lines changed

CrashReporter.xcodeproj/project.pbxproj

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -525,6 +525,7 @@
525525
C2CBA40824586975001B775F /* CrashReporter.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = 8DC2EF5B0486A6940098B216 /* CrashReporter.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
526526
C2DCD88124658A63007322C5 /* mach_exc.defs in Sources */ = {isa = PBXBuildFile; fileRef = 0581B520168FDB280098C103 /* mach_exc.defs */; };
527527
C2DCD88224658A63007322C5 /* mach_exc.defs in Sources */ = {isa = PBXBuildFile; fileRef = 0581B520168FDB280098C103 /* mach_exc.defs */; platformFilter = maccatalyst; };
528+
C2E312032869BF1700CD5C50 /* libCrashReporter.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 05E731F30EFA1AAB005EDFB7 /* libCrashReporter.a */; };
528529
C2F0ACA024AB7C28004890EC /* CrashReporterFramework.m in Sources */ = {isa = PBXBuildFile; fileRef = C2F0AC9F24AB7C28004890EC /* CrashReporterFramework.m */; };
529530
C2F0ACA124AB7C28004890EC /* CrashReporterFramework.m in Sources */ = {isa = PBXBuildFile; fileRef = C2F0AC9F24AB7C28004890EC /* CrashReporterFramework.m */; };
530531
C2F0ACA224AB7C28004890EC /* CrashReporterFramework.m in Sources */ = {isa = PBXBuildFile; fileRef = C2F0AC9F24AB7C28004890EC /* CrashReporterFramework.m */; };
@@ -980,6 +981,13 @@
980981
remoteGlobalIDString = 8064D88B1C4D22E5005A8B4C;
981982
remoteInfo = "CrashReporter tvOS Framework";
982983
};
984+
C2E312042869BF1700CD5C50 /* PBXContainerItemProxy */ = {
985+
isa = PBXContainerItemProxy;
986+
containerPortal = 0867D690FE84028FC02AAC07 /* Project object */;
987+
proxyType = 1;
988+
remoteGlobalIDString = 05E731F20EFA1AAB005EDFB7;
989+
remoteInfo = "CrashReporter macOS";
990+
};
983991
F8CF2BCC246C05D100904633 /* PBXContainerItemProxy */ = {
984992
isa = PBXContainerItemProxy;
985993
containerPortal = 0867D690FE84028FC02AAC07 /* Project object */;
@@ -1332,6 +1340,7 @@
13321340
isa = PBXFrameworksBuildPhase;
13331341
buildActionMask = 2147483647;
13341342
files = (
1343+
C2E312032869BF1700CD5C50 /* libCrashReporter.a in Frameworks */,
13351344
);
13361345
runOnlyForDeploymentPostprocessing = 0;
13371346
};
@@ -2558,6 +2567,7 @@
25582567
);
25592568
dependencies = (
25602569
C259BD4B2869ADAE00DBCE48 /* PBXTargetDependency */,
2570+
C2E312052869BF1700CD5C50 /* PBXTargetDependency */,
25612571
);
25622572
name = "CrashReporter macOS Static Framework";
25632573
productInstallPath = "$(HOME)/Library/Frameworks";
@@ -3685,6 +3695,11 @@
36853695
target = 8064D88B1C4D22E5005A8B4C /* CrashReporter tvOS Framework */;
36863696
targetProxy = C2CBA40E245869F4001B775F /* PBXContainerItemProxy */;
36873697
};
3698+
C2E312052869BF1700CD5C50 /* PBXTargetDependency */ = {
3699+
isa = PBXTargetDependency;
3700+
target = 05E731F20EFA1AAB005EDFB7 /* CrashReporter macOS */;
3701+
targetProxy = C2E312042869BF1700CD5C50 /* PBXContainerItemProxy */;
3702+
};
36883703
F8CF2BCD246C05D100904633 /* PBXTargetDependency */ = {
36893704
isa = PBXTargetDependency;
36903705
target = C2B90D952456FBD000834AFB /* CrashReporter iOS Universal */;
@@ -4168,17 +4183,15 @@
41684183
buildSettings = {
41694184
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
41704185
DEFINES_MODULE = YES;
4171-
DYLIB_INSTALL_NAME_BASE = "$(INSTALL_PATH)";
41724186
EFFECTIVE_PLATFORM_NAME = "-macosx-static";
4173-
EXPORTED_SYMBOLS_FILE = Resources/CrashReporter.exp;
41744187
GENERATE_MASTER_OBJECT_FILE = YES;
41754188
INFOPLIST_FILE = Resources/Info.plist;
41764189
INSTALL_PATH = "@rpath";
4190+
LIBRARY_SEARCH_PATHS = "$(BUILD_DIR)/$(CONFIGURATION)-macosx";
41774191
MACH_O_TYPE = staticlib;
41784192
MODULEMAP_FILE = Resources/CrashReporter.modulemap;
41794193
OTHER_LDFLAGS = "-ObjC";
4180-
PRELINK_LIBS = "$(CONFIGURATION_BUILD_DIR)/lib$(PRODUCT_NAME).a";
4181-
PRODUCT_NAME = CrashReporter;
4194+
PRELINK_LIBS = "$(BUILD_DIR)/$(CONFIGURATION)-macosx/lib$(PRODUCT_NAME).a";
41824195
SDKROOT = macosx;
41834196
SKIP_INSTALL = YES;
41844197
};
@@ -4189,17 +4202,15 @@
41894202
buildSettings = {
41904203
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
41914204
DEFINES_MODULE = YES;
4192-
DYLIB_INSTALL_NAME_BASE = "$(INSTALL_PATH)";
41934205
EFFECTIVE_PLATFORM_NAME = "-macosx-static";
4194-
EXPORTED_SYMBOLS_FILE = Resources/CrashReporter.exp;
41954206
GENERATE_MASTER_OBJECT_FILE = YES;
41964207
INFOPLIST_FILE = Resources/Info.plist;
41974208
INSTALL_PATH = "@rpath";
4209+
LIBRARY_SEARCH_PATHS = "$(BUILD_DIR)/$(CONFIGURATION)-macosx";
41984210
MACH_O_TYPE = staticlib;
41994211
MODULEMAP_FILE = Resources/CrashReporter.modulemap;
42004212
OTHER_LDFLAGS = "-ObjC";
4201-
PRELINK_LIBS = "$(CONFIGURATION_BUILD_DIR)/lib$(PRODUCT_NAME).a";
4202-
PRODUCT_NAME = CrashReporter;
4213+
PRELINK_LIBS = "$(BUILD_DIR)/$(CONFIGURATION)-macosx/lib$(PRODUCT_NAME).a";
42034214
SDKROOT = macosx;
42044215
SKIP_INSTALL = YES;
42054216
};

Scripts/combine-xcframework.sh

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
#!/bin/sh
22
set -e
33

4-
LINKER_TYPE="static"
5-
64
# Remove the previous version of the xcframework.
75
rm -rf "${BUILT_PRODUCTS_DIR}/${PRODUCT_NAME}.xcframework"
8-
rm -rf "${BUILT_PRODUCTS_DIR}/${PRODUCT_NAME}-${LINKER_TYPE}.xcframework"
6+
rm -rf "${BUILT_PRODUCTS_DIR}/${PRODUCT_NAME}-static.xcframework"
97

108
# Combine all frameworks into xcframework.
119
for sdk in iphoneos iphonesimulator appletvos appletvsimulator maccatalyst; do
@@ -19,8 +17,8 @@ framework_path="${BUILD_DIR}/${CONFIGURATION}-macosx/${PRODUCT_NAME}.framework"
1917
xcframeworks+=( -framework "${framework_path}")
2018

2119
# Add macOS with static framework to CrashReporter Static XCFramework.
22-
framework_path="${BUILD_DIR}/${CONFIGURATION}-macosx-${LINKER_TYPE}/${PRODUCT_NAME}.framework"
20+
framework_path="${BUILD_DIR}/${CONFIGURATION}-macosx-static/${PRODUCT_NAME}.framework"
2321
xcframeworksStatic+=( -framework "${framework_path}")
2422

2523
xcodebuild -create-xcframework "${xcframeworks[@]}" -output "${BUILT_PRODUCTS_DIR}/${PRODUCT_NAME}.xcframework"
26-
xcodebuild -create-xcframework "${xcframeworksStatic[@]}" -output "${BUILT_PRODUCTS_DIR}/${PRODUCT_NAME}-${LINKER_TYPE}.xcframework"
24+
xcodebuild -create-xcframework "${xcframeworksStatic[@]}" -output "${BUILT_PRODUCTS_DIR}/${PRODUCT_NAME}-static.xcframework"

0 commit comments

Comments
 (0)