Skip to content

Installation page layout issues #9499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Vitaliy-1 opened this issue Nov 9, 2023 · 9 comments
Closed

Installation page layout issues #9499

Vitaliy-1 opened this issue Nov 9, 2023 · 9 comments
Assignees
Labels
UI/UX Issues affecting the user interface/user experience
Milestone

Comments

@Vitaliy-1
Copy link
Contributor

Describe the bug
Installation page underwent unintended CSS modifications, e.g., paragraph, heading margins

To Reproduce
Steps to reproduce the behavior:

  1. Set installed to Off in the config
  2. Go to the installation page
  3. See the layout

What application are you using?
OJS, OMP and OPS main branch

Additional information
installation_page

@Vitaliy-1 Vitaliy-1 added this to the 3.5 Internal milestone Nov 9, 2023
@jonasraoni jonasraoni added the UI/UX Issues affecting the user interface/user experience label Jan 31, 2024
@asmecher
Copy link
Member

@jardakotesovec, could you or Blessie have a look at this as a blocker for 3.5.0? Hopefully it's a quick fix.

@jardakotesovec jardakotesovec self-assigned this May 24, 2025
jardakotesovec added a commit to jardakotesovec/ui-library that referenced this issue May 27, 2025
jardakotesovec added a commit to jardakotesovec/ojs that referenced this issue May 27, 2025
jardakotesovec added a commit to jardakotesovec/pkp-lib that referenced this issue May 27, 2025
jardakotesovec added a commit to jardakotesovec/ui-library that referenced this issue May 27, 2025
@jardakotesovec
Copy link
Contributor

jardakotesovec commented May 27, 2025

I underestimated the impact of the tailwind normalisation defaults. And also missed this bug report. Sorry for dealing with this one last minute.

I did explore various places and templates to identify which UIs might be impacted. I identified mostly being impacted the install/upgrade page and than the import/export plugins. For these I reapplied good defaults for h,ul,li,p elements to get quickly back to good layout.

There is couple other places which needed just small tweaks. Its impossible to always find all screens.. so there for sure will be something not looking ideal, but should not be anything significant.

PRs.
ojs:pkp/ojs#4915
omp: pkp/omp#2019
pkp-lib: #11426
ui-library: pkp/ui-library#628

@blesildaramirez Can you have a look? Since this is hard to scope - as its about exploring dusty corners of the app - I would suggest to time box it to 2hours max...

jardakotesovec added a commit to jardakotesovec/omp that referenced this issue May 27, 2025
@Tribunal33
Copy link
Contributor

@blesildaramirez and @jardakotesovec, if this is a general code fix there is no need to apply scope. Just close when finished. We can triage the bugs when they are found individually.

jardakotesovec added a commit to jardakotesovec/ojs that referenced this issue May 27, 2025
jardakotesovec added a commit to jardakotesovec/pkp-lib that referenced this issue May 27, 2025
jardakotesovec added a commit to jardakotesovec/pkp-lib that referenced this issue May 27, 2025
jardakotesovec added a commit to jardakotesovec/omp that referenced this issue May 27, 2025
@jardakotesovec
Copy link
Contributor

Merged to 3.5 and main. Closing.

@asmecher
Copy link
Member

It looks like this is still affecting the Submission Checklist, which is entered in Settings > Workflow > Submission > Author Guidance. List items entered there (including the defaults) present without bullets on the beginning of the submission process.

@asmecher asmecher reopened this May 28, 2025
@Tribunal33
Copy link
Contributor

Can confirm original bug was fixed with @jardakotesovec changes. Bullets can be seen on installation form now.

Image

@asmecher also correct in that Submission checklist missing bullet points. Like I said before though since there is no specific scope to verify we can close this and re-open when new areas are found. Fix the new area first and then close please.

Image

jardakotesovec added a commit to jardakotesovec/ui-library that referenced this issue Jun 9, 2025
jardakotesovec added a commit to jardakotesovec/ui-library that referenced this issue Jun 9, 2025
…s, apply on description and other html fields
jardakotesovec added a commit to jardakotesovec/pkp-lib that referenced this issue Jun 9, 2025
jardakotesovec added a commit to jardakotesovec/ui-library that referenced this issue Jun 9, 2025
…s, apply on description and other html fields
jardakotesovec added a commit to jardakotesovec/ui-library that referenced this issue Jun 9, 2025
…s, apply on description and other html fields
@jardakotesovec
Copy link
Contributor

ui-library: pkp/ui-library#639
pkp-lib: #11470
ojs: pkp/ojs#4915
omp: pkp/omp#2019

@blesildaramirez Can you please review? Basically since Alec pointed out that this might affects also vue.js components, where we accept html inputs - I renamed the class to semantic-defaults and applied it to also bunch of "v-html" elements.

jardakotesovec added a commit to jardakotesovec/ui-library that referenced this issue Jun 9, 2025
jardakotesovec added a commit to pkp/ui-library that referenced this issue Jun 10, 2025
…iptions and place with html (#639)

* pkp/pkp-lib#9499 introduce semantic-defaults instead of legacyDefaults, apply on description and other html fields
jardakotesovec added a commit to pkp/ui-library that referenced this issue Jun 10, 2025
…iptions and place with html (#639)

* pkp/pkp-lib#9499 introduce semantic-defaults instead of legacyDefaults, apply on description and other html fields
jardakotesovec added a commit to pkp/ui-library that referenced this issue Jun 10, 2025
@jardakotesovec
Copy link
Contributor

@Tribunal33 All merged, can you check it out? Thanks!

@Tribunal33
Copy link
Contributor

Looks like a lot of changes so I spent a little while checking all legacy settings pages. I couldn't find any issues. The Submission checklist and install checklist all appear correctly now.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX Issues affecting the user interface/user experience
Projects
None yet
Development

No branches or pull requests

6 participants