-
Notifications
You must be signed in to change notification settings - Fork 462
Installation page layout issues #9499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jardakotesovec, could you or Blessie have a look at this as a blocker for 3.5.0? Hopefully it's a quick fix. |
I underestimated the impact of the tailwind normalisation defaults. And also missed this bug report. Sorry for dealing with this one last minute. I did explore various places and templates to identify which UIs might be impacted. I identified mostly being impacted the install/upgrade page and than the import/export plugins. For these I reapplied good defaults for h,ul,li,p elements to get quickly back to good layout. There is couple other places which needed just small tweaks. Its impossible to always find all screens.. so there for sure will be something not looking ideal, but should not be anything significant. PRs. @blesildaramirez Can you have a look? Since this is hard to scope - as its about exploring dusty corners of the app - I would suggest to time box it to 2hours max... |
@blesildaramirez and @jardakotesovec, if this is a general code fix there is no need to apply scope. Just close when finished. We can triage the bugs when they are found individually. |
Merged to 3.5 and main. Closing. |
It looks like this is still affecting the Submission Checklist, which is entered in Settings > Workflow > Submission > Author Guidance. List items entered there (including the defaults) present without bullets on the beginning of the submission process. |
Can confirm original bug was fixed with @jardakotesovec changes. Bullets can be seen on installation form now. @asmecher also correct in that Submission checklist missing bullet points. Like I said before though since there is no specific scope to verify we can close this and re-open when new areas are found. Fix the new area first and then close please. |
…s, apply on description and other html fields
…s, apply on description and other html fields
…s, apply on description and other html fields
ui-library: pkp/ui-library#639 @blesildaramirez Can you please review? Basically since Alec pointed out that this might affects also vue.js components, where we accept html inputs - I renamed the class to semantic-defaults and applied it to also bunch of "v-html" elements. |
…iptions and place with html (#639) * pkp/pkp-lib#9499 introduce semantic-defaults instead of legacyDefaults, apply on description and other html fields
…iptions and place with html (#639) * pkp/pkp-lib#9499 introduce semantic-defaults instead of legacyDefaults, apply on description and other html fields
@Tribunal33 All merged, can you check it out? Thanks! |
Describe the bug
Installation page underwent unintended CSS modifications, e.g., paragraph, heading margins
To Reproduce
Steps to reproduce the behavior:
installed
toOff
in the configWhat application are you using?
OJS, OMP and OPS main branch
Additional information

The text was updated successfully, but these errors were encountered: