Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move article & blog titles back into the lede header? #23

Open
paperdigits opened this issue Jun 26, 2016 · 2 comments
Open

Move article & blog titles back into the lede header? #23

paperdigits opened this issue Jun 26, 2016 · 2 comments

Comments

@paperdigits
Copy link
Contributor

At least for the articles, on a desktop, when the page loads there is an image that takes up the whole screen, but not text until you scroll. It is a little strange. I was messing with moving the title and subtitle back into the middle of the lede header. I can polish them and make a pull request, if you'd like.

@patdavid
Copy link
Member

I think I probably originally had it like that at one time, but decided against it for a few different reasons.

We can certainly revisit and have a look at it again - did you have any mockups of what you're thinking? If I recall I was overlaying a gradient of some sort to darken/lighten the image for better text clarity of the title/sub (similar to the articles list page).

@paperdigits
Copy link
Contributor Author

I'll update this with a screenshot a bit later, I'm right on the middle of re-factoring some stuff on my sass branch.

I found a nice piece of css that'll center the block that holds the title & subtitle, and I tried to overlay a dark gradient (as light as possible before the text becomes unreadable), and added a 1px drop shadow to the text to try and help set it off. It might also benefit, at desktop resolutions, to have the title and subtitle a bit larger. I'll play with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants