Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slice 3: Extract e2e application #9431

Open
fungairino opened this issue Nov 7, 2024 · 2 comments
Open

Slice 3: Extract e2e application #9431

fungairino opened this issue Nov 7, 2024 · 2 comments
Assignees

Comments

@fungairino
Copy link
Collaborator

@fungairino
Copy link
Collaborator Author

I think we need to punt on this one until we merge the app into the monorepo. The e2e package depends on logic from "@/runtime/brickYaml", which we would need to extract to a library. However this same module is imported by the app. I'd prefer if we didn't duplicate code just for this issue - we can tackle this at the same time once merged.

@grahamlangford
Copy link
Collaborator

Let's go ahead and remove it from this epic and plug it in the appropriate phase/epic when we get there then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants