Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployed mod can't find integration configuration when configuration switched #9212

Closed
twschiller opened this issue Sep 27, 2024 · 1 comment
Labels
bug Something isn't working can't reproduce customer Required for a customer projct

Comments

@twschiller
Copy link
Contributor

twschiller commented Sep 27, 2024

Describe the bug

To Reproduce

NOTE: I've been unable to reproduce locally. But haven't tried with an OAuth2 PKCE integration. See Slack for email addresses of impacted users. (Customer dev things the issue might have resolved itself. It also hasn't shown up in error telemetry for 1 day+: https://app.pixiebrix.com/teams/ec096a08-58f3-4efd-b2ab-b153bd903533/deployments/434b2ffb-c379-423a-966d-32832c53199e?tabKey=errors)

Steps to reproduce the behavior:

  1. Assign a deployment to restricted users with a pushdown OAuth2 PKCE integration
  2. Create a new configuration for the integration
  3. Switch the deployment to use the new configuration

Actual behavior

When running sidebar, user sees error that integration configuration id corresponding to the new configuration can't be found

Expected behavior

User is able to use the mod after the deployment updates

Discussion

Mitigations

Potential mitigations

  • Verify the user is in a group with permissions to access the configuration
  • Pause/Unpause the deployment in the Admin Console to force extension deployment updater to try fetching configurations and re-activating the mod
  • Refresh the Extension Console to force extension to refetch local integration configurations
  • Restart the browser profile. On restart, the extension will refetch local integration configurations

Screenshots/Loom

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Chrome
  • Extension Version: 2.1.2

Next Steps

  • In background deployment update code, report an error to Datadog if the deployment references an unknown integration configuration (i.e., the user doesn't have access to it)
    • What do we want the behavior to be? Stop deployment activation? Or report but activate the deployment knowing the mod will error at runtime?
    • @Pashaminkovsky I think we should automatically open the Extension Console
  • In the Extension Console deployment update code:
    • Show an error if a deployment can't be activated because it references an unknown integration configuration
@twschiller twschiller added bug Something isn't working triage labels Sep 27, 2024
@twschiller twschiller self-assigned this Sep 27, 2024
@twschiller twschiller added customer Required for a customer projct can't reproduce labels Sep 27, 2024
@twschiller twschiller removed their assignment Sep 27, 2024
@twschiller twschiller changed the title Integration configuration not switched in deployment Deployed mod can't find integration configuration Sep 27, 2024
@twschiller twschiller changed the title Deployed mod can't find integration configuration Deployed mod can't find integration configuration when configuration switched Sep 27, 2024
@twschiller twschiller removed the triage label Sep 27, 2024
@mnholtz
Copy link
Collaborator

mnholtz commented Oct 8, 2024

@mnholtz mnholtz closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working can't reproduce customer Required for a customer projct
Projects
None yet
Development

No branches or pull requests

2 participants