[Tool] turn on clang-tidy for all source code files (backport StarRocks#44990) (StarRocks#49112)

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Co-authored-by: Kevin Cai <[email protected]>

Author: mergify[bot]

.clang-tidy

@@ -13,7 +13,7 @@ Checks: >
     modernize-replace-auto-ptr,
     modernize-replace-disallow-copy-and-assign-macro,
     modernize-replace-random-shuffle,
-    modernize-return-braced-init-list,
+    -modernize-return-braced-init-list,
     modernize-shrink-to-fit,
     modernize-unary-static-assert,
     modernize-use-bool-literals,

be/CMakeLists.txt

@@ -598,6 +598,12 @@ endforeach()
 # Check Clang-Tidy
 include(cmake_modules/FindClangTidy.cmake)
 
+if (CLANG_TIDY_PATH)
+    # enable clang-tidy check for all source code files
+    set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY_PATH}" "--fix" "--fix-errors")
+endif()
+
+
 # Check if functions are supported in this platform. All flags will generated
 # in gensrc/build/common/env_config.h.
 # You can check funcion here which depends on platform. Don't forget add this

be/cmake_modules/FindClangTidy.cmake

@@ -2,7 +2,7 @@ option(WITH_CLANG_TIDY "Use clang-tidy static analyzer" OFF)
 
 if (${WITH_CLANG_TIDY})
     find_program (CLANG_TIDY_CACHE_BIN NAMES "clang-tidy-cache")
-    find_program (CLANG_TIDY_BIN NAMES "clang-tidy-16" "clang-tidy-15" "clang-tidy-14" "clang-tidy-13" "clang-tidy-12" "clang-tidy")
+    find_program (CLANG_TIDY_BIN NAMES "clang-tidy-17" "clang-tidy-16" "clang-tidy-15" "clang-tidy-14" "clang-tidy-13" "clang-tidy")
 
     if (CLANG_TIDY_CACHE_BIN)
         set (CLANG_TIDY_PATH "${CLANG_TIDY_CACHE_BIN};${CLANG_TIDY_BIN}" CACHE STRING "Cache for clang-tidy")
@@ -14,6 +14,5 @@ if (${WITH_CLANG_TIDY})
         message (STATUS "Find clang-tidy: ${CLANG_TIDY_PATH}.")
     else ()
         message (FATAL_ERROR "clang-tidy is not found")
-        # message (WARNING "clang-tidy is not found")
     endif ()
-endif()
+endif()

be/src/agent/CMakeLists.txt

@@ -12,10 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-if (CLANG_TIDY_PATH)
-    set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY_PATH}")
-endif()
-
 set(LIBRARY_OUTPUT_PATH "${BUILD_DIR}/src/agent")
 
 # where to put generated binaries

be/src/bench/CMakeLists.txt

@@ -12,10 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-if (CLANG_TIDY_PATH)
-    set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY_PATH}")
-endif()
-
 ADD_BE_BENCH(${SRC_DIR}/bench/chunks_sorter_bench)
 ADD_BE_BENCH(${SRC_DIR}/bench/runtime_filter_bench)
 ADD_BE_BENCH(${SRC_DIR}/bench/csv_reader_bench)

be/src/block_cache/CMakeLists.txt

@@ -12,10 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-if (CLANG_TIDY_PATH)
-    set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY_PATH}")
-endif()
-
 # where to put generated libraries
 set(LIBRARY_OUTPUT_PATH "${BUILD_DIR}/src/block_cache")
 

be/src/column/CMakeLists.txt

@@ -14,10 +14,6 @@
 
 set(LIBRARY_OUTPUT_PATH "${BUILD_DIR}/src/column")
 
-if (CLANG_TIDY_PATH)
-    set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY_PATH}")
-endif()
-
 add_library(Column STATIC
         array_column.cpp
         adaptive_nullable_column.cpp

be/src/common/CMakeLists.txt

@@ -14,10 +14,6 @@
 
 set(LIBRARY_OUTPUT_PATH "${BUILD_DIR}/src/common")
 
-if (CLANG_TIDY_PATH)
-    set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY_PATH}")
-endif()
-
 add_library(Common STATIC
   daemon.cpp
   greplog.cpp

be/src/connector/CMakeLists.txt

@@ -14,10 +14,6 @@
 
 set(LIBRARY_OUTPUT_PATH "${BUILD_DIR}/src/connector")
 
-if (CLANG_TIDY_PATH)
-    set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY_PATH}")
-endif ()
-
 add_library(Connector STATIC
         connector.cpp
         hive_connector.cpp

be/src/exec/arrow_to_json_converter.cpp

@@ -205,7 +205,7 @@ static Status convert_single_arrow_struct(const StructArray* array, int offset,
     builder->openObject();
     const StructType* struct_type = array->struct_type();
     for (int i = 0; i < array->num_fields(); i++) {
-        auto field = array->field(i);
+        const auto& field = array->field(i);
         RETURN_IF_ERROR(convert_arrow_to_json_element(field.get(), field->type_id(), offset,
                                                       struct_type->field(i)->name(), builder));
     }
@@ -240,7 +240,7 @@ static StatusOr<std::string> convert_array_element_to_string(const Array* array,
 }
 
 static Status convert_single_arrow_map(const MapArray* array, int offset, vpack::Builder* builder) {
-    auto item_array = array->items();
+    const auto& item_array = array->items();
 
     builder->openObject();
     Type::type item_type = item_array->type_id();