-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tile rename step fails when running on windows #35
Labels
Comments
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The winfs-injector fails on the last step when attempting to rename the tile from a
.pivotal.zip
to a.pivotal
file.This issue is only reproducible on Windows (Windows 10, Windows Server 2019/2022).
Error Output:
Reproduction steps
pivotal.zip
Expected behavior
The injector should not fail on Windows and the output tile should have the extension
.pivotal
Additional context
It seems that the
github.com/jhoonb/archivex
dependency used to create the zip is not correctly closing the zip file after completion. While it does seem to close the writer fromzip.NewWriter
, it does not close the file fromos.Create
.https://github.com/jhoonb/archivex/blob/master/archivex.go#L64
On windows, this results in a permission denied because the file is still opened.
Local testing with a revised version of
archivex
seems to fix the issue.The text was updated successfully, but these errors were encountered: