Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Go 1.23 looks like it is causing counterfeiter to have a bad day #508

Open
crhntr opened this issue Sep 28, 2024 · 0 comments
Labels
go Pull requests that update Go code

Comments

@crhntr
Copy link
Member

crhntr commented Sep 28, 2024

After I run go mod edit -go 1.23
When I run go generate ./...
Then I get the following error:

target is not a named type
exit status 1
internal/commands/init_test.go:20: running "go": exit status 1

I tried updating counterfeiter. We should do that. It did not help in this case.

I have a few suspicions on how to fix this and will give it a try sometime soon but for now we need to pin to 1.22. We have till around March 2025 to figure this out.

@crhntr crhntr added the go Pull requests that update Go code label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

No branches or pull requests

1 participant