Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: WithAdditionalMiddleware() option #291

Merged
merged 1 commit into from
Feb 5, 2024
Merged

feat: WithAdditionalMiddleware() option #291

merged 1 commit into from
Feb 5, 2024

Conversation

blgm
Copy link
Member

@blgm blgm commented Jan 26, 2024

Allows custom middleware to be added after the default middleware.

Resolves #273

@blgm
feat: WithAdditionalMiddleware() option
6cd3677 
Allows custom middleware to be added *after* the default middleware.

Resolves #273
@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186922158

The labels on this github issue will be updated when the story is started.

@blgm blgm mentioned this pull request Jan 26, 2024
Closed
@blgm
Copy link
Member Author

blgm commented Jan 28, 2024 •
edited
Loading

On reflection, users can add new middleware just by calling Use() on the router returned by New(), but maybe that’s relying on the implementation.
This is not accurate as we return an http.Handler not a chi.Router

@blgm blgm merged commit 70c69f2 into main Feb 5, 2024
4 checks passed
@blgm blgm deleted the additionalmiddlware branch February 5, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pivotal-marcela-campo pivotal-marcela-campo pivotal-marcela-campo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibility to register a custom middle ware
3 participants
@blgm @cf-gitbot @pivotal-marcela-campo