std::string Pistache::Http::Header::Authorization::getBearerToken() . Where art thou?

[mowijo]

I feel std::string Pistache::Http::Header::Authorization::getBearerToken() is missing while its siblings

• std::string Pistache::Http::Header::Authorization::getBasicUser()
• std::string Pistache::Http::Header::Authorization::getBasicPassword()

exist.

Is there a design reason for lack of that method or has it just not been implemented yet? It it is the latter, I shall get on with it immediately.

[kiplingw]

The latter. I implemented basic authorization a long time ago in #725. Don't forget to add a unit test.

[mowijo]

🥳

[mowijo]

The latter. I implemented basic authorization a long time ago in #725.

But it wasn't merged. How comes? Never mind. I apparently failed reading comprehension in school

[dgreatwood]

Hi @mowijo -

Just to confirm what I think you already understood - #725 implemented BasicUser/BasicPassword, and that support was merged.

If you would like to propose a PR related to bearer token use, then that sounds good to me and I'm sure we'd be happy to take a look.

Existing mentions of bearer in the code base you can see here:
https://github.com/search?q=repo%3Apistacheio%2Fpistache%20bearer&type=code

Thanks.

[winkler-pixop]

I got it , thank you, and I am on it!

Thanks, Morten

[mowijo]

There is a PR for that now: #1258

Please let me know what you think about that.