Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add support for zstd compression #1200

Open
kiplingw opened this issue Apr 7, 2024 · 3 comments
Open

[FEATURE REQUEST] Add support for zstd compression #1200

kiplingw opened this issue Apr 7, 2024 · 3 comments

Comments

@kiplingw
Copy link
Member

kiplingw commented Apr 7, 2024

We currently have br (Brotli) and deflate compression codecs among our list of Content-Encoder support. Zstd is the new kid on the block. It is a fast lossless compression codec created by Facebook. We don't currently have support for it.

To implement support should be fairly straightforward in recycling the now already familiar pattern for the two other codecs in Pistache. The reference C implementation is available on Debian based systems as libzstd-dev.

A PR needs to update the build environment, ensuring building with support for it is optional; the d/control and d/rules would also need to modified with the new build dependency, our README to mention it, the minor version bumped, and a unit test added.

@EdgarModesto23
Copy link
Contributor

@kiplingw Hi! Is this currently being worked on? I'd love to help with it.

@kiplingw
Copy link
Member Author

Hey @EdgarModesto23. Thanks for showing initiative.

It is not currently being worked on, but we would certainly welcome a PR. You could take a look at #1177 and #1178 for an example of how we added Brotli support, informed the build environment of the required dependencies, and added a unit test to make sure it all works.

@EdgarModesto23
Copy link
Contributor

@kiplingw Awesome!, I'll work on a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants