-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
peerconnection: SetRemoteDescription should validate against inconsistent track and mimetypes #2314
Comments
Besides the track type + mimetype mismatch, there might be other worthwhile validation to do. |
Here's an example of the borked SDP that was being passed to setRemoteDescription
|
Would it be ok if i try to take a crack at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Your environment.
What did you do?
Using janus 0.x prior to this PR surfaced an issue where, when given a borked SDP where both rtx and opus were mapped to payload type 97, I was seeing a track with
RtpCodecTypeAudio
but mimetypevideo/rtx
More details here: meetecho/janus-gateway#3078 (comment)
And details on how to run Janus + Pion to test in general here: pion/example-webrtc-applications#120 (comment)
What did you expect?
SetRemoteDescription
should probably error out on this kind of mismatchWhat happened?
No errors and when receiving the track and switching on
track.Kind()
the track's mimetype wasvideo/rtx
, and I only caught this when I started parsing the mimetype (whereas previously I'd assumed it had to be Opus).The text was updated successfully, but these errors were encountered: