Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please make ProtectionProfile methods public #258

Closed
sirzooro opened this issue Feb 18, 2024 · 1 comment · Fixed by #260
Closed

Please make ProtectionProfile methods public #258

sirzooro opened this issue Feb 18, 2024 · 1 comment · Fixed by #260

Comments

@sirzooro
Copy link
Contributor

Summary

Please make ProtectionProfile methods public

Motivation

I am implementing SRTP support for my RTSP Server. I need to send key management parameters using MIKEY protocol to RTSP client. They include lengths of key, salt, etc.

Describe alternatives you've considered

I added constants for these values to my code. Calling ProtectionProfile methods to get these values would result in cleaner code.
@Sean-Der
Copy link
Member

That sounds great! Mind opening a PR?

@sirzooro sirzooro mentioned this issue Feb 23, 2024
Merged
Sean-Der pushed a commit to sirzooro/pion_srtp that referenced this issue Feb 25, 2024
@sirzooro @Sean-Der
Make ProtectionProfile methods public
4ce5dff 
This allows to get values like key length and use them with key
management protocols like MIKEY, instead of creating own constants
for this.

Resolves pion#258
sirzooro added a commit to sirzooro/pion_srtp that referenced this issue Jul 7, 2024
@sirzooro
Make ProtectionProfile methods public
0308887 
This allows to get values like key length and use them with key
management protocols like MIKEY, instead of creating own constants
for this.

Resolves pion#258
sirzooro added a commit to sirzooro/pion_srtp that referenced this issue Jul 8, 2024
@sirzooro
Make ProtectionProfile methods public
0c244b8 
This allows to get values like key length and use them with key
management protocols like MIKEY, instead of creating own constants
for this.

Resolves pion#258
sirzooro added a commit that referenced this issue Jul 8, 2024
@sirzooro
Make ProtectionProfile methods public
e3e6d11 
This allows to get values like key length and use them with key
management protocols like MIKEY, instead of creating own constants
for this.

Resolves #258
sirzooro added a commit to sirzooro/pion_srtp that referenced this issue Jul 8, 2024
@sirzooro
Make ProtectionProfile methods public
dbc471e 
This allows to get values like key length and use them with key
management protocols like MIKEY, instead of creating own constants
for this.

Resolves pion#258
@sirzooro sirzooro mentioned this issue Jul 8, 2024
Merged
sirzooro added a commit that referenced this issue Jul 8, 2024
@sirzooro
Make ProtectionProfile methods public
f94600d 
This allows to get values like key length and use them with key
management protocols like MIKEY, instead of creating own constants
for this.

Resolves #258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make ProtectionProfile methods public sirzooro/pion_srtp
2 participants
@Sean-Der @sirzooro