We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On line 14, out is truncated to length tailOffset: https://github.com/pions/srtp/blob/bc58b55b1a0d101267701ae3ea00412cb77bc918/srtcp.go#L14
out
tailOffset
However, on line 21, access of out[tailOffset:] is attempted, which results in an out-of-bounds panic: https://github.com/pions/srtp/blob/bc58b55b1a0d101267701ae3ea00412cb77bc918/srtcp.go#L21
out[tailOffset:]
Believe line 21 should be:
srtcpIndexBuffer := encrypted[tailOffset : tailOffset+srtcpIndexSize]
The text was updated successfully, but these errors were encountered:
Oof nice catch @thinkski
It’s a bummer that none of the tests caught this. I will have to figure out why, I guess we only test unencrypted RTCP?
You up for opening a PR for this? I can grab instead if you are busy!
Sorry, something went wrong.
thinkski
Successfully merging a pull request may close this issue.
On line 14,
out
is truncated to lengthtailOffset
:https://github.com/pions/srtp/blob/bc58b55b1a0d101267701ae3ea00412cb77bc918/srtcp.go#L14
However, on line 21, access of
out[tailOffset:]
is attempted, which results in an out-of-bounds panic:https://github.com/pions/srtp/blob/bc58b55b1a0d101267701ae3ea00412cb77bc918/srtcp.go#L21
Believe line 21 should be:
The text was updated successfully, but these errors were encountered: