Cover SessionSRTP with basic tests

Add basic read/write/close testing

Relates to #28

Author: Sean-Der

session_srtcp.go

@@ -22,6 +22,8 @@ type SessionSRTCP struct {
 func NewSessionSRTCP(conn net.Conn, config *Config) (*SessionSRTCP, error) {
 	if config == nil {
 		return nil, errors.New("no config provided")
+	} else if conn == nil {
+		return nil, errors.New("no conn provided")
 	}
 
 	loggerFactory := config.LoggerFactory

session_srtp.go

@@ -22,6 +22,8 @@ type SessionSRTP struct {
 func NewSessionSRTP(conn net.Conn, config *Config) (*SessionSRTP, error) {
 	if config == nil {
 		return nil, errors.New("no config provided")
+	} else if conn == nil {
+		return nil, errors.New("no conn provided")
 	}
 
 	loggerFactory := config.LoggerFactory
@@ -53,12 +55,6 @@ func NewSessionSRTP(conn net.Conn, config *Config) (*SessionSRTP, error) {
 	return s, nil
 }
 
-// Start initializes any crypto context and allows reading/writing to begin
-func (s *SessionSRTP) Start(localMasterKey, localMasterSalt, remoteMasterKey, remoteMasterSalt []byte, profile ProtectionProfile, nextConn net.Conn) error {
-	s.session.nextConn = nextConn
-	return s.session.start(localMasterKey, localMasterSalt, remoteMasterKey, remoteMasterSalt, profile, s)
-}
-
 // OpenWriteStream returns the global write stream for the Session
 func (s *SessionSRTP) OpenWriteStream() (*WriteStreamSRTP, error) {
 	return s.writeStream, nil

session_srtp_test.go

@@ -0,0 +1,88 @@
+package srtp
+
+import (
+	"bytes"
+	"net"
+	"testing"
+	"time"
+
+	"github.com/pion/rtp"
+	"github.com/pion/transport/test"
+)
+
+func TestSessionSRTPNoConfig(t *testing.T) {
+	if _, err := NewSessionSRTP(nil, nil); err == nil {
+		t.Fatal("NewSessionSRTP should error if not config was provided")
+	}
+}
+
+func TestSessionSRTP(t *testing.T) {
+	lim := test.TimeOut(time.Second * 5)
+	defer lim.Stop()
+
+	report := test.CheckRoutines(t)
+	defer report()
+
+	const (
+		testSSRC      = 5000
+		rtpHeaderSize = 12
+	)
+	testPayload := []byte{0x00, 0x01, 0x03, 0x04}
+	readBuffer := make([]byte, rtpHeaderSize+len(testPayload))
+
+	aPipe, bPipe := net.Pipe()
+	config := &Config{
+		Profile: ProtectionProfileAes128CmHmacSha1_80,
+		Keys: SessionKeys{
+			[]byte{0xE1, 0xF9, 0x7A, 0x0D, 0x3E, 0x01, 0x8B, 0xE0, 0xD6, 0x4F, 0xA3, 0x2C, 0x06, 0xDE, 0x41, 0x39},
+			[]byte{0x0E, 0xC6, 0x75, 0xAD, 0x49, 0x8A, 0xFE, 0xEB, 0xB6, 0x96, 0x0B, 0x3A, 0xAB, 0xE6},
+			[]byte{0xE1, 0xF9, 0x7A, 0x0D, 0x3E, 0x01, 0x8B, 0xE0, 0xD6, 0x4F, 0xA3, 0x2C, 0x06, 0xDE, 0x41, 0x39},
+			[]byte{0x0E, 0xC6, 0x75, 0xAD, 0x49, 0x8A, 0xFE, 0xEB, 0xB6, 0x96, 0x0B, 0x3A, 0xAB, 0xE6},
+		},
+	}
+
+	aSession, err := NewSessionSRTP(aPipe, config)
+	if err != nil {
+		t.Fatal(err)
+	} else if aSession == nil {
+		t.Fatal("NewSessionSRTP did not error, but returned nil session")
+	}
+
+	bSession, err := NewSessionSRTP(bPipe, config)
+	if err != nil {
+		t.Fatal(err)
+	} else if bSession == nil {
+		t.Fatal("NewSessionSRTP did not error, but returned nil session")
+	}
+
+	aWriteStream, err := aSession.OpenWriteStream()
+	if err != nil {
+		t.Fatal(err)
+	}
+	if _, err = aWriteStream.WriteRTP(&rtp.Header{SSRC: testSSRC}, append([]byte{}, testPayload...)); err != nil {
+		t.Fatal(err)
+	}
+
+	bReadStream, ssrc, err := bSession.AcceptStream()
+	if err != nil {
+		t.Fatal(err)
+	} else if ssrc != testSSRC {
+		t.Fatalf("SSRC mismatch during accept exp(%v) actual%v)", testSSRC, ssrc)
+	}
+
+	if _, err = bReadStream.Read(readBuffer); err != nil {
+		t.Fatal(err)
+	}
+
+	if !bytes.Equal(testPayload, readBuffer[rtpHeaderSize:]) {
+		t.Fatalf("Sent buffer does not match the one received exp(%v) actual(%v)", testPayload, readBuffer[rtpHeaderSize:])
+	}
+
+	if err = aSession.Close(); err != nil {
+		t.Fatal(err)
+	}
+
+	if err = bSession.Close(); err != nil {
+		t.Fatal(err)
+	}
+}