flight3: respect curves configuration #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #588 +/- ##
==========================================
+ Coverage 80.07% 80.13% +0.05%
==========================================
Files 101 101
Lines 5330 5330
==========================================
+ Hits 4268 4271 +3
+ Misses 687 684 -3
Partials 375 375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Snawoot
force-pushed
the
flight3_fix_curves
branch
from
6a86681
to
dd4605b
Compare
Sean-Der
force-pushed
the
flight3_fix_curves
branch
from
dd4605b
to
68a9945
Compare
|
I added a test, after CI passes will merge! |
Sean-Der
force-pushed
the
flight3_fix_curves
branch
from
68a9945
to
1c07d3b
Compare
Reuse logic from Flight1 to ensure correct behaviour. Signed-off-by: Vladislav Yarmak <[email protected]>
Sean-Der
force-pushed
the
flight3_fix_curves
branch
from
1c07d3b
to
8bf6f8c
Compare
Sean-Der
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As far as I understand Flight3 is pretty much like Flight1, but with Cookie. So I just reuse logic from Flight1 to ensure correct behaviour.
Reference issue
Fixes #587