-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The post-deploy webhook is currently only called on successful deploys #517
Comments
@sbaogang While looking at the code, I think there are some inconsistencies here on how we handle the deploy event and webhooks.
` if (succeeded * 10000 >= sucThreshold * total) {
`
` Should these two be in the same place? Should we send the notification for both succeeding and failing state? |
Right now the post-deploy webhook is only called on successful deploys and the deploy state is not updated before calling the webhook. This causes the deploy state to always be RUNNING when the webhook is being called, so the deploy state variable substitution is currently meaningless.
The text was updated successfully, but these errors were encountered: