Skip to content

Commit af4fcc2

Browse files
committed
make rolling noise quieter
1 parent cf64c16 commit af4fcc2

File tree

3 files changed

+19
-9
lines changed

3 files changed

+19
-9
lines changed

06-audio/audio_brainstorming.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,3 +99,13 @@ be used in the same segment, as segment header codes $F0-$FF are
9999
reserved. This is why quick parameters are assigned such that either
100100
3 is not used or not used with a deep parameter. Pulse duty 3 is
101101
redundant, and muted triangle needs no wave change.
102+
103+
Showing it off
104+
--------------
105+
A GIF is inadequate when asking for feedback on sound effects.
106+
Fortunately, bgb can save audio to an uncompressed wave file
107+
and video in whatever VFW codec is installed.
108+
109+
ffmpeg -i bgb-1540876262.avi -i bgb-1540876262.wav \
110+
-s 320x288 -sws_flags neighbor -pix_fmt yuv420p \
111+
libbet.mp4

src/audio.z80

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ sfx_table:
4141
dw fx_launch
4242

4343
fx_roll:
44-
db ENVF_DPAR|ENVF_PITCH|1, $4A, $5E
45-
db ENVF_DPAR|ENVF_PITCH|7, $50, $54
44+
db ENVF_DPAR|ENVF_PITCH|1, $1A, $5E
45+
db ENVF_DPAR|ENVF_PITCH|7, $20, $54
4646
if TEST_PNOISE_BUG
4747
db ENVF_PITCH|5, $4F
4848
else
@@ -52,13 +52,13 @@ fx_roll:
5252
db ENVF_PITCH|5, $47
5353
db ENVF_PITCH|7, $54
5454
db ENVF_PITCH|2, $55
55-
db ENVF_DPAR|ENVF_PITCH|1, $52, $5E
55+
db ENVF_DPAR|ENVF_PITCH|1, $22, $5E
5656
db ENVF_PITCH|1, $57
5757
db $FF
5858
fx_rolltojump:
59-
db ENVF_DPAR|ENVF_PITCH|1, $4A, $5E
60-
db ENVF_DPAR|ENVF_PITCH|2, $50, $54
61-
db ENVF_PITCH|2, $25
59+
db ENVF_DPAR|ENVF_PITCH|1, $1A, $5E
60+
db ENVF_PITCH|2, $54
61+
db ENVF_DPAR|ENVF_PITCH|2, $50, $25
6262
db $FF
6363
fx_jump:
6464
db ENVF_DPAR|ENVF_PITCH|$80, $59, 45
@@ -73,8 +73,8 @@ fx_jump:
7373
fx_land:
7474
db ENVF_DPAR|ENVF_PITCH|0, $C1, $24
7575
db ENVF_PITCH|1, $46
76-
db ENVF_DPAR|ENVF_PITCH|11, $67, $54
77-
db ENVF_DPAR|ENVF_PITCH|3, $63, $5D
76+
db ENVF_DPAR|ENVF_PITCH|11, $63, $54
77+
db ENVF_DPAR|ENVF_PITCH|3, $25, $5D
7878
db ENVF_PITCH|1, $56
7979
db ENVF_PITCH|1, $57
8080
db $FF

src/global.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,6 @@ FORCE_FLOOR_SIZE equ 0
6262

6363
; There's a bug in BGB's implementation of 127-step noise.
6464
; GB stops a noise early under certain conditions; BGB does not.
65-
TEST_PNOISE_BUG equ 1
65+
TEST_PNOISE_BUG equ 0
6666

6767
ENDC

0 commit comments

Comments
 (0)