From 2631c8015d35cfacbe712a961d039b5812cdcf38 Mon Sep 17 00:00:00 2001
From: guo-shaoge <shaoge1994@163.com>
Date: Tue, 28 Jan 2025 15:42:48 +0800
Subject: [PATCH] fix compilation error on arm64

Signed-off-by: guo-shaoge <shaoge1994@163.com>
---
 dbms/src/Columns/ColumnDecimal.cpp | 132 ++++++++++++++++++++++++++++-
 dbms/src/Columns/ColumnDecimal.h   |  88 +++----------------
 2 files changed, 143 insertions(+), 77 deletions(-)

diff --git a/dbms/src/Columns/ColumnDecimal.cpp b/dbms/src/Columns/ColumnDecimal.cpp
index 36a774975ca..17cc8908650 100644
--- a/dbms/src/Columns/ColumnDecimal.cpp
+++ b/dbms/src/Columns/ColumnDecimal.cpp
@@ -139,6 +139,137 @@ const char * ColumnDecimal<T>::deserializeAndInsertFromArena(const char * pos, c
     }
 }
 
+template <typename T>
+void ColumnDecimal<T>::countSerializeByteSizeForCmp(PaddedPODArray<size_t> & byte_size, const TiDB::TiDBCollatorPtr &) const
+{
+    countSerializeByteSizeImpl<true>(byte_size);
+}
+
+template <typename T>
+void ColumnDecimal<T>::countSerializeByteSize(PaddedPODArray<size_t> & byte_size) const
+{
+    countSerializeByteSizeImpl<false>(byte_size);
+}
+
+
+template <typename T>
+void ColumnDecimal<T>::countSerializeByteSizeForCmpColumnArray(
+        PaddedPODArray<size_t> & byte_size,
+        const IColumn::Offsets & array_offsets,
+        const TiDB::TiDBCollatorPtr &) const
+{
+    countSerializeByteSizeForColumnArrayImpl<true>(byte_size, array_offsets);
+}
+
+template <typename T>
+void ColumnDecimal<T>::countSerializeByteSizeForColumnArray(
+        PaddedPODArray<size_t> & byte_size,
+        const IColumn::Offsets & array_offsets) const
+{
+    countSerializeByteSizeForColumnArrayImpl<false>(byte_size, array_offsets);
+}
+
+
+template <typename T>
+void ColumnDecimal<T>::serializeToPosForCmp(
+        PaddedPODArray<char *> & pos,
+        size_t start,
+        size_t length,
+        bool has_null,
+        const TiDB::TiDBCollatorPtr &,
+        String *) const
+{
+    if (has_null)
+        serializeToPosImpl</*has_null=*/true, /*for_compare=*/true>(pos, start, length);
+    else
+        serializeToPosImpl</*has_null=*/false, /*for_compare=*/true>(pos, start, length);
+}
+
+template <typename T>
+void ColumnDecimal<T>::serializeToPos(PaddedPODArray<char *> & pos, size_t start, size_t length, bool has_null) const
+{
+    if (has_null)
+        serializeToPosImpl</*has_null=*/true, /*for_compare=*/false>(pos, start, length);
+    else
+        serializeToPosImpl</*has_null=*/false, /*for_compare=*/false>(pos, start, length);
+}
+
+template <typename T>
+void ColumnDecimal<T>::serializeToPosForCmpColumnArray(
+        PaddedPODArray<char *> & pos,
+        size_t start,
+        size_t length,
+        bool has_null,
+        const IColumn::Offsets & array_offsets,
+        const TiDB::TiDBCollatorPtr &,
+        String *) const
+{
+    if (has_null)
+        serializeToPosForColumnArrayImpl</*has_null=*/true, /*for_compare=*/true>(
+                pos,
+                start,
+                length,
+                array_offsets);
+    else
+        serializeToPosForColumnArrayImpl</*has_null=*/false, /*for_compare=*/true>(
+                pos,
+                start,
+                length,
+                array_offsets);
+}
+
+template <typename T>
+void ColumnDecimal<T>::serializeToPosForColumnArray(
+        PaddedPODArray<char *> & pos,
+        size_t start,
+        size_t length,
+        bool has_null,
+        const IColumn::Offsets & array_offsets) const
+{
+    if (has_null)
+        serializeToPosForColumnArrayImpl</*has_null=*/true, /*for_compare=*/false>(
+                pos,
+                start,
+                length,
+                array_offsets);
+    else
+        serializeToPosForColumnArrayImpl</*has_null=*/false, /*for_compare=*/false>(
+                pos,
+                start,
+                length,
+                array_offsets);
+}
+
+template <typename T>
+void ColumnDecimal<T>::deserializeForCmpAndInsertFromPos(PaddedPODArray<char *> & pos, bool use_nt_align_buffer)
+{
+    deserializeAndInsertFromPosImpl<true>(pos, use_nt_align_buffer);
+}
+
+template <typename T>
+void ColumnDecimal<T>::deserializeAndInsertFromPos(PaddedPODArray<char *> & pos, bool use_nt_align_buffer)
+{
+    deserializeAndInsertFromPosImpl<false>(pos, use_nt_align_buffer);
+}
+
+template <typename T>
+void ColumnDecimal<T>::deserializeForCmpAndInsertFromPosColumnArray(
+        PaddedPODArray<char *> & pos,
+        const IColumn::Offsets & array_offsets,
+        bool use_nt_align_buffer)
+{
+    deserializeAndInsertFromPosForColumnArrayImpl<true>(pos, array_offsets, use_nt_align_buffer);
+}
+
+template <typename T>
+void ColumnDecimal<T>::deserializeAndInsertFromPosForColumnArray(
+        PaddedPODArray<char *> & pos,
+        const IColumn::Offsets & array_offsets,
+        bool use_nt_align_buffer)
+{
+    deserializeAndInsertFromPosForColumnArrayImpl<false>(pos, array_offsets, use_nt_align_buffer);
+}
+
 template <typename T>
 template <bool for_compare>
 void ColumnDecimal<T>::countSerializeByteSizeImpl(PaddedPODArray<size_t> & byte_size) const
@@ -160,7 +291,6 @@ void ColumnDecimal<T>::countSerializeByteSizeImpl(PaddedPODArray<size_t> & byte_
     }
 }
 
-// TODO add unit test
 template <typename T>
 template <bool for_compare>
 void ColumnDecimal<T>::countSerializeByteSizeForColumnArrayImpl(
diff --git a/dbms/src/Columns/ColumnDecimal.h b/dbms/src/Columns/ColumnDecimal.h
index 18211b13177..d44eb992107 100644
--- a/dbms/src/Columns/ColumnDecimal.h
+++ b/dbms/src/Columns/ColumnDecimal.h
@@ -173,28 +173,16 @@ class ColumnDecimal final : public COWPtrHelper<ColumnVectorHelper, ColumnDecima
         String &) const override;
     const char * deserializeAndInsertFromArena(const char * pos, const TiDB::TiDBCollatorPtr &) override;
 
-    void countSerializeByteSizeForCmp(PaddedPODArray<size_t> & byte_size, const TiDB::TiDBCollatorPtr &) const override
-    {
-        countSerializeByteSizeImpl<true>(byte_size);
-    }
-    void countSerializeByteSize(PaddedPODArray<size_t> & byte_size) const override
-    {
-        countSerializeByteSizeImpl<false>(byte_size);
-    }
+    void countSerializeByteSizeForCmp(PaddedPODArray<size_t> & byte_size, const TiDB::TiDBCollatorPtr &) const override;
+    void countSerializeByteSize(PaddedPODArray<size_t> & byte_size) const override;
 
     void countSerializeByteSizeForCmpColumnArray(
         PaddedPODArray<size_t> & byte_size,
         const IColumn::Offsets & array_offsets,
-        const TiDB::TiDBCollatorPtr &) const override
-    {
-        countSerializeByteSizeForColumnArrayImpl<true>(byte_size, array_offsets);
-    }
+        const TiDB::TiDBCollatorPtr &) const override;
     void countSerializeByteSizeForColumnArray(
         PaddedPODArray<size_t> & byte_size,
-        const IColumn::Offsets & array_offsets) const override
-    {
-        countSerializeByteSizeForColumnArrayImpl<false>(byte_size, array_offsets);
-    }
+        const IColumn::Offsets & array_offsets) const override;
 
     void serializeToPosForCmp(
         PaddedPODArray<char *> & pos,
@@ -202,20 +190,8 @@ class ColumnDecimal final : public COWPtrHelper<ColumnVectorHelper, ColumnDecima
         size_t length,
         bool has_null,
         const TiDB::TiDBCollatorPtr &,
-        String *) const override
-    {
-        if (has_null)
-            serializeToPosImpl</*has_null=*/true, /*for_compare=*/true>(pos, start, length);
-        else
-            serializeToPosImpl</*has_null=*/false, /*for_compare=*/true>(pos, start, length);
-    }
-    void serializeToPos(PaddedPODArray<char *> & pos, size_t start, size_t length, bool has_null) const override
-    {
-        if (has_null)
-            serializeToPosImpl</*has_null=*/true, /*for_compare=*/false>(pos, start, length);
-        else
-            serializeToPosImpl</*has_null=*/false, /*for_compare=*/false>(pos, start, length);
-    }
+        String *) const override;
+    void serializeToPos(PaddedPODArray<char *> & pos, size_t start, size_t length, bool has_null) const override;
 
     void serializeToPosForCmpColumnArray(
         PaddedPODArray<char *> & pos,
@@ -224,65 +200,25 @@ class ColumnDecimal final : public COWPtrHelper<ColumnVectorHelper, ColumnDecima
         bool has_null,
         const IColumn::Offsets & array_offsets,
         const TiDB::TiDBCollatorPtr &,
-        String *) const override
-    {
-        if (has_null)
-            serializeToPosForColumnArrayImpl</*has_null=*/true, /*for_compare=*/true>(
-                pos,
-                start,
-                length,
-                array_offsets);
-        else
-            serializeToPosForColumnArrayImpl</*has_null=*/false, /*for_compare=*/true>(
-                pos,
-                start,
-                length,
-                array_offsets);
-    }
+        String *) const override;
     void serializeToPosForColumnArray(
         PaddedPODArray<char *> & pos,
         size_t start,
         size_t length,
         bool has_null,
-        const IColumn::Offsets & array_offsets) const override
-    {
-        if (has_null)
-            serializeToPosForColumnArrayImpl</*has_null=*/true, /*for_compare=*/false>(
-                pos,
-                start,
-                length,
-                array_offsets);
-        else
-            serializeToPosForColumnArrayImpl</*has_null=*/false, /*for_compare=*/false>(
-                pos,
-                start,
-                length,
-                array_offsets);
-    }
+        const IColumn::Offsets & array_offsets) const override;
 
-    void deserializeForCmpAndInsertFromPos(PaddedPODArray<char *> & pos, bool use_nt_align_buffer) override
-    {
-        deserializeAndInsertFromPosImpl<true>(pos, use_nt_align_buffer);
-    }
-    void deserializeAndInsertFromPos(PaddedPODArray<char *> & pos, bool use_nt_align_buffer) override
-    {
-        deserializeAndInsertFromPosImpl<false>(pos, use_nt_align_buffer);
-    }
+    void deserializeForCmpAndInsertFromPos(PaddedPODArray<char *> & pos, bool use_nt_align_buffer) override;
+    void deserializeAndInsertFromPos(PaddedPODArray<char *> & pos, bool use_nt_align_buffer) override;
 
     void deserializeForCmpAndInsertFromPosColumnArray(
         PaddedPODArray<char *> & pos,
         const IColumn::Offsets & array_offsets,
-        bool use_nt_align_buffer) override
-    {
-        deserializeAndInsertFromPosForColumnArrayImpl<true>(pos, array_offsets, use_nt_align_buffer);
-    }
+        bool use_nt_align_buffer) override;
     void deserializeAndInsertFromPosForColumnArray(
         PaddedPODArray<char *> & pos,
         const IColumn::Offsets & array_offsets,
-        bool use_nt_align_buffer) override
-    {
-        deserializeAndInsertFromPosForColumnArrayImpl<false>(pos, array_offsets, use_nt_align_buffer);
-    }
+        bool use_nt_align_buffer) override;
 
     void flushNTAlignBuffer() override;