From 18a547c88d1fc7086964683473232cc516bcbfb2 Mon Sep 17 00:00:00 2001 From: Weizhen Wang Date: Mon, 27 Jan 2025 13:48:09 +0800 Subject: [PATCH] update Signed-off-by: Weizhen Wang --- pkg/expression/util.go | 13 +++++++++++++ .../core/operator/logicalop/expression_util.go | 16 +--------------- 2 files changed, 14 insertions(+), 15 deletions(-) diff --git a/pkg/expression/util.go b/pkg/expression/util.go index b74322c3f8c88..83e56a12b1097 100644 --- a/pkg/expression/util.go +++ b/pkg/expression/util.go @@ -2162,3 +2162,16 @@ func binaryDurationWithMS(pos int, paramValues []byte, pos += 4 return pos, fmt.Sprintf("%s.%06d", dur, microSecond) } + +// IsConstFalse is used to check whether the expression is a constant false expression. +func IsConstFalse(expr Expression) bool { + if e, ok := expr.(*ScalarFunction); ok { + switch e.FuncName.L { + case ast.LT, ast.LE, ast.GT, ast.GE, ast.EQ, ast.NE: + if constExpr, ok := e.GetArgs()[1].(*Constant); ok && constExpr.Value.IsNull() && constExpr.DeferredExpr == nil { + return true + } + } + } + return false +} diff --git a/pkg/planner/core/operator/logicalop/expression_util.go b/pkg/planner/core/operator/logicalop/expression_util.go index 7ce66b5cd6651..1a2eb08dc8e1c 100644 --- a/pkg/planner/core/operator/logicalop/expression_util.go +++ b/pkg/planner/core/operator/logicalop/expression_util.go @@ -16,27 +16,13 @@ package logicalop import ( "github.com/pingcap/tidb/pkg/expression" - "github.com/pingcap/tidb/pkg/parser/ast" "github.com/pingcap/tidb/pkg/planner/core/base" ) -// isConstFalse is used to check whether the expression is a constant false expression. -func isConstFalse(expr expression.Expression) bool { - if e, ok := expr.(*expression.ScalarFunction); ok { - switch e.FuncName.L { - case ast.LT, ast.LE, ast.GT, ast.GE, ast.EQ, ast.NE: - if constExpr, ok := e.GetArgs()[1].(*expression.Constant); ok && constExpr.Value.IsNull() && constExpr.DeferredExpr == nil { - return true - } - } - } - return false -} - // Conds2TableDual builds a LogicalTableDual if cond is constant false or null. func Conds2TableDual(p base.LogicalPlan, conds []expression.Expression) base.LogicalPlan { for _, cond := range conds { - if isConstFalse(cond) { + if expression.IsConstFalse(cond) { if expression.MaybeOverOptimized4PlanCache(p.SCtx().GetExprCtx(), conds) { return nil }