Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow max-execution-time parameter for SyncDiffInspector #845

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow max-execution-time parameter for SyncDiffInspector #845

wants to merge 2 commits into from

Conversation

zph
Copy link

@zph zph commented Jan 31, 2025 •
edited
Loading

Allows passing max-execution-time to sync-diff-inspector to allow it to override a stricter cluster level max-execution-time.

The default remains the same that no max-execution-time will be set if the config file lacks this parameter. It's backwards compatible.

What problem does this PR solve?

Issue Number: close #844

What is changed and how it works?

New argument for sync-diff-inspector to set session level max_execution_time value.

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Side effects

  • New cli argument available w/ backwards compatible default

Related changes

  • Need to update the documentation

QUESTIONS

  • I'm unsure how / where to update docs, please advise.
  • I added the field check to an existing test, advise if you want it in new test
  • I marked the field as omitempty to avoid backwards compatibility break if users are strictly parsing json output logs. Advise if you want to break existing interface of that log by outputting max-execution-time arg

@zph
Allow max-execution-time parameter for SyncDiffInspector
b1cbb1c 
Allows passing max-execution-time to sync-diff-inspector to allow
it to override a stricter cluster level max-execution-time.

The default remains the same that no max-execution-time will be set
if the config file lacks this parameter. It's backwards compatible.
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 31, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot requested a review from Rustin170506 January 31, 2025 21:58
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elsa0520 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CLAassistant
Copy link

CLAassistant commented Jan 31, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 31, 2025

Welcome @zph!

It looks like this is your first PR to pingcap/tidb-tools 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb-tools. 😃

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 31, 2025

Hi @zph. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

Assignees
No one assigned
Labels
contribution do-not-merge/release-note-label-needed first-time-contributor needs-ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add max_execution_time parameter for sync diff inspector
2 participants
@zph @CLAassistant