minor kriswallsmith#791 Avoid using Twig_Environment::getFunction to identify Assetic functions (stof)

This PR was merged into the 1.4-dev branch.

Discussion
----------

Avoid using Twig_Environment::getFunction to identify Assetic functions

As of Assetic 1.3.0, the Twig functions are using a special node class, which can be used to identify them instead.
The `getFunction` method is intended to be marked as an internal one in twigphp/Twig#1889

Commits
-------

39b99e8 Avoid using Twig_Environment::getFunction to identify Assetic functions

Author: stof

src/Assetic/Extension/Twig/TwigFormulaLoader.php

@@ -70,27 +70,25 @@ private function loadNode(\Twig_Node $node)
                     'vars'    => $node->getAttribute('vars'),
                 ),
             );
-        } elseif ($node instanceof \Twig_Node_Expression_Function) {
+        } elseif ($node instanceof AsseticFilterNode) {
             $name = $node->getAttribute('name');
 
-            if ($this->twig->getFunction($name) instanceof AsseticFilterFunction) {
-                $arguments = array();
-                foreach ($node->getNode('arguments') as $argument) {
-                    $arguments[] = eval('return '.$this->twig->compile($argument).';');
-                }
-
-                $invoker = $this->twig->getExtension('Assetic\\Extension\\Twig\\AsseticExtension')->getFilterInvoker($name);
+            $arguments = array();
+            foreach ($node->getNode('arguments') as $argument) {
+                $arguments[] = eval('return '.$this->twig->compile($argument).';');
+            }
 
-                $inputs  = isset($arguments[0]) ? (array) $arguments[0] : array();
-                $filters = $invoker->getFilters();
-                $options = array_replace($invoker->getOptions(), isset($arguments[1]) ? $arguments[1] : array());
+            $invoker = $this->twig->getExtension('Assetic\Extension\Twig\AsseticExtension')->getFilterInvoker($name);
 
-                if (!isset($options['name'])) {
-                    $options['name'] = $invoker->getFactory()->generateAssetName($inputs, $filters, $options);
-                }
+            $inputs  = isset($arguments[0]) ? (array) $arguments[0] : array();
+            $filters = $invoker->getFilters();
+            $options = array_replace($invoker->getOptions(), isset($arguments[1]) ? $arguments[1] : array());
 
-                $formulae[$options['name']] = array($inputs, $filters, $options);
+            if (!isset($options['name'])) {
+                $options['name'] = $invoker->getFactory()->generateAssetName($inputs, $filters, $options);
             }
+
+            $formulae[$options['name']] = array($inputs, $filters, $options);
         }
 
         foreach ($node as $child) {