Skip to content

Commit bd50928

Browse files
authored
Catch throwable instead of exception to avoid that the indexing queue breaks (#180)
1 parent 63990c0 commit bd50928

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/Service/Serializer/AssetTypeSerializationHandler/DocumentSerializationHandler.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
use Pimcore\Model\Asset;
2525
use Pimcore\Model\Asset\Document;
2626
use Pimcore\Model\Asset\Image;
27+
use Throwable;
2728

2829
class DocumentSerializationHandler extends AbstractHandler
2930
{
@@ -56,7 +57,7 @@ private function getImageThumbnail(Document $document): ?string
5657
{
5758
try {
5859
return $document->getImageThumbnail(Image\Thumbnail\Config::getPreviewConfig())->getPath();
59-
} catch (Exception $e) {
60+
} catch (Throwable $e) {
6061
$this->logger->error('Thumbnail generation failed for document asset: ' .
6162
$document->getId() .
6263
' error ' .

src/Service/Serializer/AssetTypeSerializationHandler/ImageSerializationHandler.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@
1616

1717
namespace Pimcore\Bundle\GenericDataIndexBundle\Service\Serializer\AssetTypeSerializationHandler;
1818

19-
use Exception;
2019
use Pimcore\Bundle\GenericDataIndexBundle\Enum\SearchIndex\FieldCategory\SystemField\Asset\ImageSystemField;
2120
use Pimcore\Bundle\GenericDataIndexBundle\Model\Search\Asset\SearchResult\AssetSearchResultItem;
2221
use Pimcore\Bundle\GenericDataIndexBundle\Model\Search\Asset\SearchResult\SearchResultItem;
2322
use Pimcore\Bundle\GenericDataIndexBundle\Traits\LoggerAwareTrait;
2423
use Pimcore\Model\Asset;
2524
use Pimcore\Model\Asset\Image;
25+
use Throwable;
2626

2727
class ImageSerializationHandler extends AbstractHandler
2828
{
@@ -53,7 +53,7 @@ private function getThumbnail(Image $image): ?string
5353
{
5454
try {
5555
return $image->getThumbnail(Image\Thumbnail\Config::getPreviewConfig())->getPath();
56-
} catch (Exception $e) {
56+
} catch (Throwable $e) {
5757
$this->logger->error('Thumbnail generation failed for image asset: ' .
5858
$image->getId() .
5959
' error ' .

0 commit comments

Comments
 (0)