-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First time using Falco #119
Comments
Oh and maybe one example of grabbing a logger inside an |
Hey Florian, Nice to meet you officially. I appreciate the time taken to provide all of this feedback. It's invaluable to the progress of the library. Some of the things you bring up are things I've thought about as well for some time. But, as a dad of two young kids and a demanding job, things don't always get the attention they deserve. I like to think I do a solid job on the critical stuff, and hopefully can continue to improve on the remainder as my time continues to free up. Now, on to your questions.
Thanks again for your time and interest. Really appreciate it. |
Hi Pim, Thanks for your response to this post! I was hesitant to post it due to its detailed criticisms. I understand time constraints might be an issue for you with this project. Life happens, and I completely understand. I'm not expecting any immediate actions; I'm simply curious about a few things. Have you considered building a community around Falco, such as finding co-maintainers to help the project grow beyond your efforts? More contributors can be beneficial in the long term. Regarding my interest, I'm looking for an excellent framework to build web servers in F# and see potential in Falco. The documentation is impressive, and such developer-first experiences are what F# needs more of.
It's disappointing that an additional file is needed just to change the port. I understand this is more related to ASP.NET Core, but in a simple Node.JS project, everything could fit in a single file. That's the appeal of the scripting approach when all requirements fit into one file.
Sometimes, I need a quick, temporary web server. I'm not aiming for production or longevity, which is why Suave is appealing—it fits into a script file for fast iteration. You might suggest
Understood. I appreciated finding the exact documentation snippet I needed.
I always appreciate a "recipes" page for quick learning. Lastly, why is there an empty array in Keep up the great work, Pim! |
Hey there,
Just gave Falco a whirl for the first time. The docs looked neat, which piqued my interest.
Here are some random thoughts I had while exploring it. Feel free to ignore them; they might just be nitpicks.
To set the stage, I've dabbled with Giraffe before, but Suave is more my jam, mainly because it's straightforward and doesn't make me deal with ASP.NET Core's intricacies. My grasp on ASP.NET Core isn't the sharpest, and that's probably going to show in some of my comments. Also, I'm one of the folks behind fsharp.formatting, so my views might be a bit skewed because of that.
So, without any particular order:
port
—no clue how that's done in ASP.NET Core, so a quick search feature would have been handy here too.webHost [||] {
in examples but had no idea what the empty array was for. A bit of a head-scratcher.HttpHandler
example. I love seeing how to handle raw request headers and bodies and set response headers and bodies directly.Didn't want to fuss over
CorsPolicyBuilder
andCorsOptions
for some localhost experiments.open
statements. If you used scripts in fsdocs, that could link directly to the actual code, keeping your docs synchronized and avoiding CI misses.Like I said, these are mostly minor points, and you've done a fantastic job with the project!
Keep it up!
The text was updated successfully, but these errors were encountered: