-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid regex patterns not properly detected. #283
Comments
It's not particularly difficult to add that to detect if you want to open a PR, but it'd have to be part of a new major release since it's a breaking change for anyone potentially using these patterns for whatever reason. |
I'm toying around with having a boolean |
I've noticed, due to how the lexer is written, it's not particularly difficult to make invalid patterns that won't be detected as being erroneous, specifically when ')' appears at weird locations.
Routes such as
"/:foo([123]+))"
, or"/:foo)([123]+)"
should give an error, but they don't.The text was updated successfully, but these errors were encountered: