Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't use getHtml() when a ContentBlocker is active #2136

Open
2 tasks done
2x2xplz opened this issue May 13, 2024 · 1 comment
Open
2 tasks done

can't use getHtml() when a ContentBlocker is active #2136

2x2xplz opened this issue May 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@2x2xplz
Copy link

2x2xplz commented May 13, 2024

Environment

Technology Version
Flutter version 3.19.6
Plugin version 6.0.0
Android version 12
iOS version
macOS version
Xcode version
Google Chrome version

Device information:

Description

Expected behavior: getHtml() should return contents of webview

Current behavior: throws an error: type 'Null' is not a subtype of type 'String'

Steps to reproduce

  1. print(ContentBlockerActionType.values);

Images

image

Stacktrace/Logcat

#0      ContentBlockerAction.fromMap (package:flutter_inappwebview_platform_interface/src/content_blocker.dart:265:68)
#1      ContentBlocker.fromMap (package:flutter_inappwebview_platform_interface/src/content_blocker.dart:27:38)
#2      _deserializeContentBlockers.<anonymous closure> (package:flutter_inappwebview_platform_interface/src/in_app_webview/in_app_webview_settings.dart:44:42)
#3      _Array.forEach (dart:core-patch/array.dart:40:8)
#4      _deserializeContentBlockers (package:flutter_inappwebview_platform_interface/src/in_app_webview/in_app_webview_settings.dart:43:28)
#5      InAppWebViewSettings.fromMap (package:flutter_inappwebview_platform_interface/src/in_app_webview/in_app_webview_settings.g.dart:1462:9)
#6      AndroidInAppWebViewController.getSettings (package:flutter_inappwebview_android/src/in_app_webview/in_app_webview_controller.dart:2054:35)
<asynchronous suspension>
#7      AndroidInAppWebViewController.getHtml (package:flutter_inappwebview_android/src/in_app_webview/in_app_webview_controller.dart:1579:38)
<asynchronous suspension>
#8      NavigatePages.execute (package:flutterclient/components/atc_webview/navigatePages.dart:175:38)
<asynchronous suspension>
#9      webviewInterceptor.<anonymous closure> (package:flutterclient/parsing/interceptors/webviewInterceptor.dart:66:31)
<asynchronous suspension>

Calling the getHtml() method causes an error when there is one or more active ContentBlockers. As shown by the stacktrace, ultimately the function constructs an InAppWebViewSettings object, which in turn requires the construction of a ContentBlocker object. Inside the function ContentBlockerActionType.fromNativeValue() is the line:

return ContentBlockerActionType.values.firstWhere((element) => element.toNativeValue() == value);

and referencing ContentBlockerActionType.values causes the error: type 'Null' is not a subtype of type 'String'

This error likely affects other functions besides just getHtml() but in my case, getHtml() was working just fine until I added a ContentBlocker to the InAppWebView.

@2x2xplz 2x2xplz added the bug Something isn't working label May 13, 2024
Copy link

👋 @2x2xplz

NOTE: This comment is auto-generated.

Are you sure you have already searched for the same problem?

Some people open new issues but they didn't search for something similar or for the same issue. Please, search for it using the GitHub issue search box or on the official inappwebview.dev website, or, also, using Google, StackOverflow, etc. before posting a new one. You may already find an answer to your problem!

If this is really a new issue, then thank you for raising it. I will investigate it and get back to you as soon as possible. Please, make sure you have given me as much context as possible! Also, if you didn't already, post a code example that can replicate this issue.

In the meantime, you can already search for some possible solutions online! Because this plugin uses native WebView, you can search online for the same issue adding android WebView [MY ERROR HERE] or ios WKWebView [MY ERROR HERE] keywords.

Following these steps can save you, me, and other people a lot of time, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant