Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce request watefall when lazy loading #18

Closed
pi0 opened this issue Mar 15, 2024 · 0 comments
Closed

Reduce request watefall when lazy loading #18

pi0 opened this issue Mar 15, 2024 · 0 comments

Comments

@pi0
Copy link
Owner

pi0 commented Mar 15, 2024 •
edited

Currently, we do lazy load shiki on client side when needed but there is a little bit of waterfall in chain that could be improved.

old:

image

updated with 3736ed8:

image

fully fixed by shikijs/shiki#624

image

Reproduction:

pnpm nuxt build playground
pnpm nuxt preview playground

Source:

  • cached loader: src
  • composable: src
  • options virtual: src

(edit something in the left pannel to see the network activity)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pi0