-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore does not include static dhcp leases without ip #5551
Comments
By the way, wouldn't it be better if these were called "permanent leases" instead of "static leases" to avoid confusion with static ip addresses which are significantly different? |
Thanks for your report. I did not track the issue down but tried it with the upcoming Pi-hole v6 (which uses a completely different approach for the backup) and it worked without issues. |
Thanks, then I'll happily wait for the new version! |
Versions
Platform
Expected behavior
When restoring data from a backup, I expect static dhcp leases to be included even if they have no ip address assigned (but the name only).
Actual behavior / bug
When restoring data from a backup, static dhcp leases without ip address are skipped (=not restored).
Steps to reproduce
Steps to reproduce the behavior:
Additional context
The missing entries are included in the backup, I can see them in the archive file unter dnsmasq.d -> pihole-static-dhcp.conf, so it seems to be the restore code that is not working as expected.
I do have quite a lot of these entries where I don't care about the actual address, but want to assign a certain name.
The text was updated successfully, but these errors were encountered: