-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container::getComponents() returns incorrect type #141
Comments
Draft
1 task
Or maybe we should even remove the stub since the arguments were deprecated in 3.1.0 and Nette has correct annotations for argument-less use. |
You can detect which version of Nette the project uses. This has similar approach: https://github.com/phpstan/phpstan-doctrine/blob/4058fdc7333cb9e46f8cf5b952cd9cb59658f2e5/src/Stubs/Doctrine/StubFilesExtensionLoader.php#L75-L84 |
Thanks for the pointer, I opened #142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
component-model 3.1.0 returns array
Container::getComponents()
when$deep === false
:nette/component-model@7f613ee
instead of
Iterator
:phpstan-nette/stubs/ComponentModel/Container.stub
Lines 11 to 13 in 8af9474
The return type should be something like
I can open a PR but not sure what to do about older versions. Should I just add conflict with
< 3.1.0
?The text was updated successfully, but these errors were encountered: