Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Enable no_mixed_echo_print fixer #864

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Dec 6, 2023

This pull request

  • enables the no_mixed_echo_print fixer
  • runs make coding-standards

Follows #559.

πŸ’β€β™‚οΈ For reference, see https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.40.2/doc/rules/alias/no_mixed_echo_print.rst.

@localheinz localheinz force-pushed the feature/no-mixed-echo-print branch from 1396d63 to 3f92052 Compare December 6, 2023 14:14
@@ -38,6 +38,7 @@
'line_ending' => true,
'new_with_parentheses' => true,
'no_extra_blank_lines' => true,
'no_mixed_echo_print' => true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this fixer can be configured with the use option to prefer echo or print.

Using the default option (echo) applies fewer changes across the code base.

@kamil-tekiela kamil-tekiela merged commit a528e6e into php:master Dec 6, 2023
2 checks passed
@localheinz localheinz deleted the feature/no-mixed-echo-print branch December 6, 2023 14:20
@localheinz
Copy link
Contributor Author

Thank you, @kamil-tekiela!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants