Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BCMath block to PHP 8.4 release page #1142

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Add BCMath block to PHP 8.4 release page #1142

merged 3 commits into from
Nov 21, 2024

Conversation

pronskiy
Copy link
Contributor

Fixes #1140

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

🚀 Preview for commit bd9daae can be found at https://web-php-pr-1142.preview.thephp.foundation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

🚀 Regression report for commit bd9daae is at https://web-php-regression-report-pr-1142.preview.thephp.foundation

@pronskiy pronskiy marked this pull request as ready for review November 21, 2024 10:36
SakiTakamachi
SakiTakamachi approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thx!

@saundefined saundefined merged commit 522c2fa into php:master Nov 21, 2024
3 checks passed
@saundefined
Copy link
Member

saundefined commented Nov 21, 2024 •
edited by sy-records
Loading

Hope, I mentioned everyone correctly :)
Added a new block about BCMath

✅ Français: @adoy @Girgias
✅ Português do Brasil: @marcosmarcolin
✅ Nederlands: @nielsdos
Spanish: @andresayac
✅ Українська: @bkosun
✅ 简体中文: @sy-records

@SakiTakamachi
Copy link
Member

Is there no Japanese version of this page?

I'll research it and make it

@bkosun bkosun mentioned this pull request Nov 21, 2024
Merged
@nielsdos nielsdos mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SakiTakamachi SakiTakamachi SakiTakamachi approved these changes

@saundefined saundefined Awaiting requested review from saundefined saundefined is a code owner

@sy-records sy-records Awaiting requested review from sy-records sy-records is a code owner

Assignees
No one assigned
Labels
Status: Preview Allowed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add BCMath changes to PHP 8.4 release page
3 participants
@pronskiy @saundefined @SakiTakamachi