Fix offcanvas menu open bug #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the click handler to the backdrop element instead of the document to close the offcanvas menu on mobile devices. Fixes php#1112
|
🚀 Regression report for commit 4c23310 is at https://web-php-regression-report-pr-1116.preview.thephp.foundation |
|
🚀 Preview for commit 4c23310 can be found at https://web-php-pr-1116.preview.thephp.foundation |
|
It's displaying properly, but there's a small problem:
The close button is selected by default after displaying |
Sets the initial focus on the first navigation item instead of the close button when opening the offcanvas nav. Improves accessibility and user experience for keyboard and screen reader users. Closes php#1118
sy-records
reviewed
Nov 8, 2024
js/common.js
Outdated
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
Should this semicolon be retained?
Suggested change
| } | |
| }; |
There was a problem hiding this comment.
Yes! Some other lines were also missing semicolons, so I just ran this navbar section through Prettier again.
saundefined
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the click handler to the backdrop element instead of the document to close the offcanvas menu on mobile devices.
Fixes #1112, fixes #1118