-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hero section styles according to BEM methodology #1107
Conversation
🚀 Regression report for commit 0ceadab is at https://web-php-regression-report-pr-1107.preview.thephp.foundation |
🚀 Preview for commit 0ceadab can be found at https://web-php-pr-1107.preview.thephp.foundation |
Everything looks great to me, just a minor suggestion (nit) in the comment I added. Once that's addressed, I think it should be good to go! |
Thanks @lhsazevedo. I accidentally overlooked it. |
LGTM Note for the person merging: Please either add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks a ton, @sy-records, and @lhsazevedo. |
Hero classes changed after php#1107. Should fix visual tests.
Thanks you! The rest of the website could indeed be refactored to follow BEM, which would help a lot with readability and maintenance. However, there's quite a bit of technical debt in the styles that goes beyond just the naming convention. We're dealing with some older techniques, like float-based layouts with clearfixes, which could definitely use a modern overhaul. Switching to Flexbox (and potentially Grid where it makes sense) would significantly improve the layout's flexibility and remove a lot of that legacy CSS. Converting to BEM alongside these structural updates would make everything cleaner and more modular. Appreciate the offer to help! It might be best to tackle it one section or block at a time, updating both the structure and the naming conventions incrementally. Thanks again! |
fixes #1102
Changes: