From 1742dcd340f706513b62145dab721dc4ae70a190 Mon Sep 17 00:00:00 2001 From: Lucas Azevedo Date: Fri, 8 Nov 2024 03:09:01 -0300 Subject: [PATCH] Fix offcanvas menu open bug Add the click handler to the backdrop element instead of the document to close the offcanvas menu on mobile devices. Fixes #1112 --- js/common.js | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/js/common.js b/js/common.js index 972710987c..a99c885f63 100644 --- a/js/common.js +++ b/js/common.js @@ -523,13 +523,10 @@ $(document).ready(function () { }; const closeOffCanvasByClickOutside = (event) => { - if ( - !offcanvasElement.contains(event.target) && - !menuButton.contains(event.target) - ) { - closeOffcanvasNav() + if (event.target === backdropElement) { + closeOffcanvasNav(); } - }; + } document .getElementById("navbar__menu-link") @@ -543,7 +540,7 @@ $(document).ready(function () { .getElementById("navbar__close-button") .addEventListener("click", closeOffcanvasNav); - document.addEventListener('click', closeOffCanvasByClickOutside); + backdropElement.addEventListener('click', closeOffCanvasByClickOutside); /*}}}*/