cs

Author: vjik

.github/workflows/cs.yml

@@ -0,0 +1,38 @@
+name: cs fixer
+
+on: [ pull_request_target ]
+
+jobs:
+  php-cs-fixer:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.head_ref }}
+          repository: ${{ github.event.pull_request.head.repo.full_name }}
+
+      - name: Install PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 8.2
+          tools: composer:v2
+          coverage: none
+
+      - name: Install Composer dependencies
+        uses: "ramsey/composer-install@v3"
+
+      - name: Run PHP CS Fixer
+        run: composer php-cs-fixer
+
+      - name: Run Rector
+        run: composer rector
+
+      - name: Commit changes
+        uses: stefanzweifel/git-auto-commit-action@v5
+        with:
+          commit_message: "Apply PHP CS Fixer and Rector changes (CI)"
+          file_pattern: '*.php'
+          disable_globbing: true

.gitignore

@@ -3,3 +3,6 @@
 
 # PHPUnit
 .phpunit.cache
+
+# PHP CS Fixer
+/.php-cs-fixer.cache

.php-cs-fixer.dist.php

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+use PhpCsFixer\Config;
+use PhpCsFixer\Finder;
+use PhpCsFixer\Runner\Parallel\ParallelConfigFactory;
+
+$finder = (new Finder())->in([
+    __DIR__ . '/src',
+    __DIR__ . '/tests',
+]);
+
+return (new Config())
+    ->setParallelConfig(ParallelConfigFactory::detect())
+    ->setRules([
+        '@PER-CS2.0' => true,
+        'no_unused_imports' => true,
+    ])
+    ->setFinder($finder);

composer.json

@@ -20,9 +20,11 @@
         "brick/money": "^0.10.0"
     },
     "require-dev": {
+        "friendsofphp/php-cs-fixer": "^3.69",
+        "infection/infection": "^0.29.12",
         "maglnet/composer-require-checker": "^4.16.1",
         "phpunit/phpunit": "^12.0.3",
-        "infection/infection": "^0.29.12",
+        "rector/rector": "^2.0",
         "vimeo/psalm": "^6.8"
     },
     "config": {
@@ -33,6 +35,8 @@
         }
     },
     "scripts": {
-        "infection": "infection --ignore-msi-with-no-mutations --only-covered"
+        "php-cs-fixer": "php-cs-fixer fix",
+        "infection": "infection --ignore-msi-with-no-mutations --only-covered",
+        "rector": "rector"
     }
 }

rector.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Php74\Rector\Closure\ClosureToArrowFunctionRector;
+use Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector;
+use Rector\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector;
+use Rector\Php82\Rector\Param\AddSensitiveParameterAttributeRector;
+
+return RectorConfig::configure()
+    ->withPaths([
+        __DIR__ . '/src',
+        __DIR__ . '/tests',
+    ])
+    ->withPhpSets(php83: true)
+    ->withSkip([
+        ClosureToArrowFunctionRector::class,
+        NullToStrictStringFuncCallArgRector::class,
+        ClassPropertyAssignToConstructorPromotionRector::class,
+    ]);

src/Domain/Account/Account.php

@@ -8,7 +8,7 @@
 
 final class Account
 {
-    private const NAME_CHARS_LIMIT = 50;
+    private const int NAME_CHARS_LIMIT = 50;
 
     /**
      * @psalm-var non-empty-string|null
@@ -62,8 +62,8 @@ private function setName(?string $name): void
                 throw new InvalidArgumentException(
                     sprintf(
                         'Account name must be null or non-empty string no greater than %d symbols.',
-                        self::NAME_CHARS_LIMIT
-                    )
+                        self::NAME_CHARS_LIMIT,
+                    ),
                 );
             }
             /** @psalm-var non-empty-string $name */

src/Domain/Account/AccountChartId.php

@@ -7,9 +7,8 @@
 final readonly class AccountChartId
 {
     public function __construct(
-        public string $value
-    ) {
-    }
+        public string $value,
+    ) {}
 
     public function isEqualTo(AccountChartId $id): bool
     {

src/Domain/Account/AccountId.php

@@ -7,9 +7,8 @@
 final readonly class AccountId
 {
     public function __construct(
-        public string $value
-    ) {
-    }
+        public string $value,
+    ) {}
 
     public function isEqualTo(AccountId $id): bool
     {

src/Domain/Account/AccountManager.php

@@ -7,14 +7,13 @@
 use PhpFinance\DoubleEntry\Domain\Account\Exception\AccountDeletionNotPossibleException;
 use PhpFinance\DoubleEntry\Domain\Posting\PostingRepositoryInterface;
 
-final class AccountManager
+final readonly class AccountManager
 {
     public function __construct(
-        private readonly AccountRepositoryInterface $accountRepository,
-        private readonly AccountIdFactoryInterface $accountIdFactory,
-        private readonly PostingRepositoryInterface $postingRepository,
-    ) {
-    }
+        private AccountRepositoryInterface $accountRepository,
+        private AccountIdFactoryInterface $accountIdFactory,
+        private PostingRepositoryInterface $postingRepository,
+    ) {}
 
     public function get(AccountId $id): Account
     {

src/Domain/Account/Exception/AccountDeletionNotPossibleException.php

@@ -6,6 +6,4 @@
 
 use RuntimeException;
 
-final class AccountDeletionNotPossibleException extends RuntimeException
-{
-}
+final class AccountDeletionNotPossibleException extends RuntimeException {}

src/Domain/Account/Exception/AccountNotFoundException.php

@@ -6,6 +6,4 @@
 
 use RuntimeException;
 
-final class AccountNotFoundException extends RuntimeException
-{
-}
+final class AccountNotFoundException extends RuntimeException {}

src/Domain/Calculator/Filter.php

@@ -18,8 +18,7 @@ public function __construct(
         private ?DateTimeImmutable $dateFrom = null,
         private ?DateTimeImmutable $dateTo = null,
         private array $currencies = [],
-    ) {
-    }
+    ) {}
 
     public function getDimensions(): array
     {

src/Domain/Posting/Entry.php

@@ -22,8 +22,7 @@ public function __construct(
         public Money $amount,
         public AccountId $accountId,
         private array $dimensions = [],
-    ) {
-    }
+    ) {}
 
     /**
      * @throws DimensionNotFoundException

src/Domain/Posting/Exception/DimensionNotFoundException.php

@@ -13,8 +13,8 @@ public function __construct(int|string $name)
         parent::__construct(
             sprintf(
                 'Entry does not have dimension "%s".',
-                $name
-            )
+                $name,
+            ),
         );
     }
 }

src/Domain/Posting/Exception/PostingNotFoundException.php

@@ -6,6 +6,4 @@
 
 use RuntimeException;
 
-final class PostingNotFoundException extends RuntimeException
-{
-}
+final class PostingNotFoundException extends RuntimeException {}

src/Domain/Posting/Factory/EntryData.php

@@ -11,6 +11,5 @@
     public function __construct(
         public Account $account,
         public array $dimensions = [],
-    ) {
-    }
+    ) {}
 }

src/Domain/Posting/Factory/PostingFactory.php

@@ -10,12 +10,11 @@
 use PhpFinance\DoubleEntry\Domain\Posting\Entry;
 use PhpFinance\DoubleEntry\Domain\Posting\Posting;
 
-final class PostingFactory
+final readonly class PostingFactory
 {
     public function __construct(
         private PostingIdFactoryInterface $postingIdFactory,
-    ) {
-    }
+    ) {}
 
     public function create(
         DateTimeImmutable $date,
@@ -40,7 +39,7 @@ public function create(
                 $amount,
                 $creditData->account->id,
                 $creditData->dimensions,
-            )
+            ),
         );
     }
 }

src/Domain/Posting/Posting.php

@@ -16,9 +16,8 @@
     public function __construct(
         public PostingId $id,
         public Entry $debit,
-        public Entry $credit
-    ) {
-    }
+        public Entry $credit,
+    ) {}
 
     public function getDate(): DateTimeImmutable
     {

src/Domain/Posting/PostingId.php

@@ -7,9 +7,8 @@
 final readonly class PostingId
 {
     public function __construct(
-        public string $value
-    ) {
-    }
+        public string $value,
+    ) {}
 
     public function isEqualTo(PostingId $id): bool
     {

src/Domain/Transaction/Exception/TransactionNotFoundException.php

@@ -6,6 +6,4 @@
 
 use RuntimeException;
 
-final class TransactionNotFoundException extends RuntimeException
-{
-}
+final class TransactionNotFoundException extends RuntimeException {}

src/Domain/Transaction/Factory/PostingData.php

@@ -13,6 +13,5 @@ public function __construct(
         public Money $amount,
         public EntryData $debitData,
         public EntryData $creditData,
-    ) {
-    }
+    ) {}
 }

src/Domain/Transaction/Factory/TransactionFactory.php

@@ -8,13 +8,12 @@
 use PhpFinance\DoubleEntry\Domain\Posting\Factory\PostingFactory;
 use PhpFinance\DoubleEntry\Domain\Transaction\Transaction;
 
-final class TransactionFactory
+final readonly class TransactionFactory
 {
     public function __construct(
         private TransactionIdFactoryInterface $transactionIdFactory,
         private PostingFactory $postingFactory,
-    ) {
-    }
+    ) {}
 
     public function create(
         DateTimeImmutable $date,

src/Domain/Transaction/Transaction.php

@@ -19,8 +19,7 @@
     public function __construct(
         public TransactionId $id,
         public array $postings,
-    ) {
-    }
+    ) {}
 
     public function getDate(): DateTimeImmutable
     {

src/Domain/Transaction/TransactionId.php

@@ -7,9 +7,8 @@
 final readonly class TransactionId
 {
     public function __construct(
-        public string $value
-    ) {
-    }
+        public string $value,
+    ) {}
 
     public function isEqualTo(TransactionId $id): bool
     {

tests/Account/AbstractAccountManagerTestCase.php

@@ -144,7 +144,7 @@ public function testDeleteWithChildren(): void
         $accountIncomes = TestFactory::createAccount('incomes');
         $accountSalary = TestFactory::createAccount(
             'salary',
-            parent: $accountIncomes
+            parent: $accountIncomes,
         );
         $accountRepository = $this->createAccountRepository($accountIncomes, $accountSalary);
         $accountManager = $this->createAccountManager(
@@ -161,7 +161,7 @@ public function testDeleteWithChildrenAndNamedAccounts(): void
         $accountIncomes = TestFactory::createAccount('acc1', name: 'Incomes');
         $accountSalary = TestFactory::createAccount(
             'salary',
-            parent: $accountIncomes
+            parent: $accountIncomes,
         );
         $accountRepository = $this->createAccountRepository($accountIncomes, $accountSalary);
         $accountManager = $this->createAccountManager(