Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong usage of OffsetTime #220

Open
C-Otto opened this issue Nov 17, 2024 · 0 comments
Open

Wrong usage of OffsetTime #220

C-Otto opened this issue Nov 17, 2024 · 0 comments

Comments

@C-Otto
Copy link

C-Otto commented Nov 17, 2024

Describe the bug
When determining the timezone offset for an image, exiftool-vendored uses the OffsetTime tag. This offset, however, corresponds to the file's modification date, not it's "original" date. As such, the timezone offset for images exported from (for example) Adobe Lightroom might be wrong.

Tag documentation: https://exiftool.org/TagNames/EXIF.html

To Reproduce
Example photo in immich-app/immich#12650 (comment)

{   
  "tz": "UTC+1",
  "tzSource": "OffsetTime",
   [...]
  "OffsetTime": "+01:00",
  "OffsetTimeOriginal": "+02:00",
  "OffsetTimeDigitized": "+02:00",
   [...]
}

This uses Immich's settings:

    defaultVideosToUTC: true,
    backfillTimezones: true,
    inferTimezoneFromDatestamps: true,
    inferTimezoneFromTimeStamp: true,
    useMWG: true,

Expected behavior
Timezone offset +02:00

Environment (please complete the following information):

  • Version of this library: 28.7.0
  • OS and version: Debian Stable
  • Node.js version: 22.11.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant