-
-
Notifications
You must be signed in to change notification settings - Fork 87
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
8db1b4f
commit db970d1
Showing
2 changed files
with
3 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db970d1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Joel,
I'm curious why this was removed?
I'm using Lookbook 2.3.4 which passes this to the preview.html.erb (https://github.com/lookbook-hq/lookbook/blob/main/app/views/lookbook/previews/preview.html.erb) in a call method. What do I replace or modify to get similar functionality as before?
If this is the wrong spot, I can open an issue in phlex or lookbook. Any help is greatly appreciated.
db970d1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update Lookbook to support Phlex 2. I’m planning to work on it this week. It may make sense to open an issue over in the Lookbook repo.
db970d1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joeldrapper Thanks, I appreciate your work on this (and Phlex 2!). I went ahead and created an issue (lookbook-hq/lookbook#673)