-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't disable adapters #183
Comments
It seems to work for me on 1.0.0-alpha. Please try there |
Nope, doesn't work. Also the whole output is now cluttered with
Huh??? Other file types as well. With Alpha 5 it seems rga just looks into everything. |
I can't reproduce this. If I run |
How can I do that? |
@runxel In this case, a minimum working example would mostly consist of you sharing a file that results in the buggy behavior when running
Yes.
|
Thank you for that @lafrenierejm. So it seems the issue is with rga not updating its config.json at all. Mine is empty except for the default comment in it. {
"adapters": "-zip"
} |
Both |
Coming back to this because this does not work at all in 0.10.6. @phiresky |
the syntax is probably |
Yes, that works! Thanks @phiresky! |
creating a list that can be both additive as well as overriding is challenging, and then getting intuitive support for the same syntax in a config file as well as cli args while keeping it comfortable is even more challenging ;) esp when the config format is added later than the cli syntax |
Since ripgrep-all isn't yet at 1.0.0, what would you think about making a breaking change to the config file schema to have two distinct lists? I'm thinking they could be something like:
|
Describe the bug
Trying to disable adapters with
--rga-adapters=-zip,sqlite
does not work.Next search will still have .zip's being searched...
(not helpful at all, it will just spit a lot of errors like:)
Operating System and Version
MacOS 13.5.2
Output of
rga --version
ripgrep-all 0.9.6
The text was updated successfully, but these errors were encountered: