Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get unit tests to pass on 32-bit systems #1667

Closed

Conversation

twoseascharlie
Copy link
Contributor

Change a few spots from int to float to allow for long numbers to work on 32-bit systems.

Resolves: phingofficial/guide#50

Signed-off-by: Charlie Cadwell [email protected]

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #1667 (080a3ee) into main (be0a65b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    phingofficial/phing#1667   +/-   ##
=========================================
  Coverage     58.22%   58.22%           
  Complexity     7009     7009           
=========================================
  Files           356      356           
  Lines         16911    16911           
=========================================
  Hits           9847     9847           
  Misses         7064     7064           
Impacted Files Coverage Δ
src/Phing/Type/Selector/DateSelector.php 64.63% <100.00%> (ø)
src/Phing/Util/SizeHelper.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0a65b...080a3ee. Read the comment docs.

@mrook mrook closed this May 16, 2022
@twoseascharlie twoseascharlie deleted the 32bit-issues branch May 16, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Document that users of 32-bit systems might encounter precision issues when running Phing
2 participants