Apply eslint

Author: crux14

.eslintrc.js

@@ -5,48 +5,14 @@ module.exports = {
   },
   parser: '@typescript-eslint/parser',
   parserOptions: {
-    sourceType: 'module',
-    parser: '@typescript-eslint/parser',
-    // project: ['./tsconfig.json'],
+    tsconfigRootDir: __dirname,
+    // project: ['./src/tsconfig.json'],
   },
   plugins: ['@typescript-eslint'],
   rules: {
     '@typescript-eslint/adjacent-overload-signatures': 'error',
     '@typescript-eslint/array-type': 'error',
     '@typescript-eslint/ban-types': 'error',
-    '@typescript-eslint/naming-convention': [
-      'error',
-      {
-        selector: 'default',
-        format: ['camelCase'],
-      },
-      {
-        selector: 'class',
-        format: ['camelCase'],
-      },
-      {
-        selector: 'typeAlias',
-        format: ['PascalCase'],
-      },
-      {
-        selector: 'interface',
-        format: ['PascalCase'],
-      },
-      {
-        selector: 'typeParameter',
-        format: ['PascalCase'],
-      },
-      {
-        selector: 'property',
-        format: null,
-      },
-      {
-        selector: 'variable',
-        format: ['camelCase', 'UPPER_CASE'],
-        leadingUnderscore: 'allow',
-        trailingUnderscore: 'allow',
-      },
-    ],
     '@typescript-eslint/consistent-type-assertions': 'error',
     '@typescript-eslint/consistent-type-definitions': 'off',
     '@typescript-eslint/explicit-member-accessibility': [
@@ -70,11 +36,12 @@ module.exports = {
         },
       },
     ],
+    // '@typescript-eslint/no-floating-promises': ['error'],
     '@typescript-eslint/no-empty-interface': 'error',
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-misused-new': 'error',
     '@typescript-eslint/no-namespace': 'error',
-    '@typescript-eslint/no-non-null-assertion': 'error',
+    '@typescript-eslint/no-non-null-assertion': 'warn',
     '@typescript-eslint/no-parameter-properties': 'off',
     '@typescript-eslint/no-use-before-declare': 'off',
     // [TODO] this does not check unused expressions completely...
@@ -139,20 +106,16 @@ module.exports = {
     'no-cond-assign': 'error',
     'no-console': 'off',
     'no-debugger': 'error',
-    'no-empty': 'error',
+    'no-empty': 'off',
     'no-eval': 'error',
     'no-extra-semi': 'off',
     'no-fallthrough': 'off',
     'no-invalid-this': 'off',
     'no-irregular-whitespace': 'off',
     'no-multiple-empty-lines': 'off',
     'no-new-wrappers': 'error',
-    'no-shadow': [
-      'error',
-      {
-        hoist: 'all',
-      },
-    ],
+    'no-shadow': 'off',
+    '@typescript-eslint/no-shadow': ['error'],
     'no-throw-literal': 'error',
     'no-trailing-spaces': 'off',
     'no-undef-init': 'error',

package.json

@@ -5,6 +5,7 @@
   "scripts": {
     "build": "node build.js debug",
     "watch": "node build.js debug watch",
+    "lint": "eslint ./src/**/*.ts",
     "publish": "node build.js production"
   },
   "keywords": [],

src/core/logger.ts

@@ -35,7 +35,7 @@ const GLOBAL_LOGLEVEL = {
   loglevel: LogLevel.WARN,
 };
 
-function setLevel(level: LogLevel) {
+function setLevel(level: LogLevel): void {
   if (typeof self !== 'undefined') {
     // @ts-ignore
     self.__wv_global_loglevel = level;
@@ -52,7 +52,7 @@ function getLevel(): LogLevel {
   }
 }
 
-function log(level: LogLevel, msg: string, header?: string) {
+function log(level: LogLevel, msg: string, header?: string): void {
   if (level < getLevel()) {
     return;
   }

src/core/ringbuffer.ts

@@ -38,29 +38,29 @@ export class WVAudioRingBuffer {
     this.options.channels = init.options.channels ?? this.options.channels;
     this.options.bufLength = init.options.bufLength ?? this.options.bufLength;
 
-    if (this.bufSet.lockSab.byteLength != 4) {
+    if (this.bufSet.lockSab.byteLength !== 4) {
       throw Error('WVAudioRingBuffer Error: ByteLength of WVAudioRingBufferBufferSet.lockSab != 4');
     }
     this.lock = new Int32Array(this.bufSet.lockSab);
 
-    if (this.bufSet.idxSabs.length != 2) {
+    if (this.bufSet.idxSabs.length !== 2) {
       throw Error('WVAudioRingBuffer Error: Length of WVAudioRingBufferBufferSet.idxSabs != 2');
     }
     for (let i = 0; i < 2; i++) {
-      if (this.bufSet.idxSabs[i].byteLength != 4) {
+      if (this.bufSet.idxSabs[i].byteLength !== 4) {
         throw Error('WVAudioRingBuffer: ByteLength of WVAudioRingBufferBufferSet.idxSabs[] != 4');
       }
     }
     this.readIdx = new Uint32Array(this.bufSet.idxSabs[0]);
     this.writeIdx = new Uint32Array(this.bufSet.idxSabs[1]);
 
-    if (this.bufSet.bufSabs.length != this.options.channels) {
+    if (this.bufSet.bufSabs.length !== this.options.channels) {
       throw Error(
         'WVAudioRingBuffer Error: Length of WVAudioRingBufferBufferSet.bufSabs != WVAudioRingBufferOptions.channels'
       );
     }
     for (let ch = 0; ch < this.options.channels; ch++) {
-      if (this.bufSet.bufSabs[ch].byteLength != 4 * this.options.bufLength) {
+      if (this.bufSet.bufSabs[ch].byteLength !== 4 * this.options.bufLength) {
         throw Error(
           'WVAudioRingBuffer: ByteLength of WVAudioRingBufferBufferSet.bufSabs[] != WVAudioRingBufferOptions.bufLength'
         );

src/core/state.ts

@@ -85,8 +85,8 @@ export class WVPlayState {
 export class WVSharedFlag {
   #buf: Int32Array;
 
-  static readonly #TRUE = 1;
-  static readonly #FALSE = 0;
+  static readonly #TRUE: number = 1;
+  static readonly #FALSE: number = 0;
 
   static fromBuffer(buf: Int32Array): WVSharedFlag {
     const dummy = false;

src/index.ts

@@ -8,32 +8,32 @@ enum PlayBtnIcon {
   FONTAWESOME_PAUSE = '',
 }
 
-function showLoader(loaderElem: HTMLElement) {
+function showLoader(loaderElem: HTMLElement): void {
   loaderElem.style.display = '';
 }
 
-function hideLoader(loaderElem: HTMLElement) {
+function hideLoader(loaderElem: HTMLElement): void {
   loaderElem.style.display = 'none';
 }
 
-function showPlayBtn(playBtnWrapperElem: HTMLElement) {
+function showPlayBtn(playBtnWrapperElem: HTMLElement): void {
   playBtnWrapperElem.style.display = '';
 }
 
-function hidePlayBtn(playBtnWrapperElem: HTMLElement) {
+function hidePlayBtn(playBtnWrapperElem: HTMLElement): void {
   playBtnWrapperElem.style.display = 'none';
 }
 
-function autohidePlayBtn(enable: boolean, playBtnWrapperElem: HTMLElement) {
+function autohidePlayBtn(enable: boolean, playBtnWrapperElem: HTMLElement): void {
   playBtnWrapperElem.style.opacity = enable ? '0' : '1';
 }
 
-function setPlayBtnIcon(icon: PlayBtnIcon, playBtnElem: HTMLElement) {
+function setPlayBtnIcon(icon: PlayBtnIcon, playBtnElem: HTMLElement): void {
   playBtnElem.innerHTML = icon;
 }
 
 window.addEventListener('beforeunload', (e) => {
-  function blockingSleep(waitMs: number) {
+  function blockingSleep(waitMs: number): void {
     const start = new Date().getTime();
     while (new Date().getTime() - start < waitMs) {}
   }
@@ -92,14 +92,14 @@ window.addEventListener('load', async () => {
     switch (player.playState()) {
       case WVPlayStateKind.PAUSED: {
         if (player.canPlay()) {
-          player.play();
+          void player.play();
           autohidePlayBtn(true, playBtnWrapperElem);
           setPlayBtnIcon(PlayBtnIcon.FONTAWESOME_PAUSE, playBtnElem);
         }
         break;
       }
       case WVPlayStateKind.PLAYING: {
-        player.pause();
+        void player.pause();
         autohidePlayBtn(false, playBtnWrapperElem);
         setPlayBtnIcon(PlayBtnIcon.FONTAWESOME_PLAY, playBtnElem);
         break;

src/media/codec/decoderWebCodecs.ts

@@ -180,7 +180,7 @@ async function createDecoder(
   stream: WVMediaStreamInfo,
   output: (frame: DecodedFrame) => void
 ): Promise<VideoDecoder | AudioDecoder | null> {
-  if (stream.type == 'video') {
+  if (stream.type === 'video') {
     return await createVideoDecoder(stream, output);
   } else {
     return await createAudioDecoder(stream, output);
@@ -194,7 +194,7 @@ export class WebCodecsMediaDecoder implements WVMediaDecoder {
   #decoder: AudioDecoder | VideoDecoder | null = null;
   #decodedFrames: DecodedFrame[] = [];
 
-  #onFrame = (data: DecodedFrame): void => {
+  #onFrame: (d: DecodedFrame) => void = (data: DecodedFrame): void => {
     data.close();
   };
 

src/media/format/demuxerMP4Box.ts

@@ -43,26 +43,30 @@ function createAVCDescription(trackIdx: number, file: MP4Box.MP4File): Uint8Arra
     return undefined;
   }
 
-  let i,
-    size = 7;
-  for (i = 0; i < avccBox.SPS.length; i++) size += 2 + avccBox.SPS[i].length;
-  for (i = 0; i < avccBox.PPS.length; i++) size += 2 + avccBox.PPS[i].length;
+  let i;
+  let size = 7;
+  for (i = 0; i < avccBox.SPS.length; i++) {
+    size += 2 + avccBox.SPS[i].length;
+  }
+  for (i = 0; i < avccBox.PPS.length; i++) {
+    size += 2 + avccBox.PPS[i].length;
+  }
 
   let id = 0;
-  let data = new Uint8Array(size);
+  const data = new Uint8Array(size);
 
-  let writeUint8 = (value: any) => {
+  const writeUint8 = (value: any): any => {
     data.set([value], id);
     id++;
   };
-  let writeUint16 = (value: any) => {
-    let arr = new Uint8Array(1);
+  const writeUint16 = (value: any): any => {
+    const arr = new Uint8Array(1);
     arr[0] = value;
-    let buffer = new Uint8Array(arr.buffer);
+    const buffer = new Uint8Array(arr.buffer);
     data.set([buffer[1], buffer[0]], id);
     id += 2;
   };
-  let writeUint8Array = (value: any) => {
+  const writeUint8Array = (value: any): any => {
     data.set(value, id);
     id += value.length;
   };
@@ -85,7 +89,7 @@ function createAVCDescription(trackIdx: number, file: MP4Box.MP4File): Uint8Arra
     writeUint8Array(avccBox.PPS[i].nalu);
   }
 
-  if (id != size) {
+  if (id !== size) {
     logger.debug('Size mismatched', 'MP4BoxMediaDemuxer');
     return undefined;
   }
@@ -100,8 +104,8 @@ function createWVMediaStreamInfo(
 ): WVMediaStreamInfo {
   const streamType = track.type;
   let streamTypeStr: WVMediaStreamType = 'other';
-  let video: WVVideoStreamInfo | undefined = undefined;
-  let audio: WVAudioStreamInfo | undefined = undefined;
+  let video: WVVideoStreamInfo | undefined;
+  let audio: WVAudioStreamInfo | undefined;
   if (streamType === 'video') {
     streamTypeStr = 'video';
     video = {
@@ -205,7 +209,7 @@ export class MP4BoxMediaDemuxer implements WVMediaDemuxer {
     });
   }
 
-  destroy() {
+  destroy(): void {
     if (this.#info) {
       for (const track of this.#info.tracks) {
         // @ts-ignore

src/player/audio/decoder.ts

@@ -5,7 +5,7 @@ import type { WVMediaStreamInfo } from '../../media/media';
 export class WVAudioDecoderWorkerFront {
   #worker: Worker;
 
-  constructor(options: {}) {
+  constructor() {
     this.#worker = new Worker(AUDIO_DECODER_WORKER_PATH, {
       type: 'module',
       name: AUDIO_DECODER_WORKER_NAME,

src/player/audio/decoderWorker/worker.ts

@@ -98,7 +98,7 @@ self.addEventListener('message', async (e) => {
           break;
         }
         if (data.frame) {
-          if (data.frame.type() == 'audio') {
+          if (data.frame.type() === 'audio') {
             await pushSamples(workerState, data.frame);
             data.frame.close();
             continue;