Feedback on Yammer from Jan

[m-beelman]

Nice feedback from @janzwanenburg. Thanks!

It displays the following data (picture below).

• "Number of reviews: 11" --> actually, I would say this is the number of 'comments', not the number of reviews. It would be very useful to distinguish the number of comments of the author (often explaining the changes) and the number of comments from others (feedback). Ideally, I'd also like the size of the comments. Maybe I would even prefer that over the amount of comments.

This is the number of review cycles in GitHub. If you want to give feedback or approve a pull request you have to start a review cycle. And for this PR there were 11 review cycles from different users.

• "Number of comments (w/o review comments): 0" --> Very confusing: Does this mean the number of empty comments?

This is bad and wrong description. Need to be fixed. This is related to the number of "reviews" (cycles) and should be renamed to "Number of reviews w/o any comments". For this example it should be 2. This is not working correctly.

• "Number of reviews that contains a comments to resolve" --> Number of non-empty review comments?

It's the opposite of the previous one. If you start a review and finish the review by checking "Comment" option it will increase this measure. Maybe it's better to phrase this as "Number of commented reviews".

• "Get the total number of participants of a PR: 3" --> "Number of participants of the PR"? Why is the number 3? I would rather have the number of reviewers (which would be 1 in this example.

Yes, that's something that is already in my mind. I created an issue to filter out comments from bots (#60). But I will look into that the number of 3 is not correct.

Ideally, I'd like to get an indication of whether the amount of feedback compared to the size of the code change is suspiciously small, which could indicate a low-quality review.

Good idea Jan. I will create a separate issue and dig deeper. :-)